Skip to content

Measurement type - Move to points and image table#195

Merged
jomey merged 2 commits into
release-0.6.xfrom
measurement_type
Aug 8, 2025
Merged

Measurement type - Move to points and image table#195
jomey merged 2 commits into
release-0.6.xfrom
measurement_type

Conversation

@jomey

@jomey jomey commented Aug 7, 2025

Copy link
Copy Markdown
Member

Refactor the schema and move the measurement type from the campaign observation to the image and points table. This allows having multiple measurements per observation.

Closes #194

Refactor the schema and move the measurement type from the campaign
observation to the image and points table. This allows having multiple
measurements per observation.

Closes #194
@codecov

codecov Bot commented Aug 7, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.73%. Comparing base (5ca4c17) to head (1d16f99).

Additional details and impacted files
@@                Coverage Diff                @@
##           release-0.6.x     #195      +/-   ##
=================================================
- Coverage          75.80%   75.73%   -0.08%     
=================================================
  Files                 21       21              
  Lines                649      647       -2     
=================================================
- Hits                 492      490       -2     
  Misses               157      157              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Version 3.8 is end of life and unsupported as 0f 2024-10
@jomey jomey force-pushed the measurement_type branch from c576752 to 1d16f99 Compare August 7, 2025 16:33
@aaarendt

aaarendt commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

This looks good - I was able to create the new schema via the successful run of the test suite.

How will name be treated now in PointObservation? As discussed in #194, the name now has the measurement type embedded. Fine if we do this in a separate PR.

@jomey

jomey commented Aug 7, 2025

Copy link
Copy Markdown
Member Author

This looks good - I was able to create the new schema via the successful run of the test suite.

How will name be treated now in PointObservation? As discussed in #194, the name now has the measurement type embedded. Fine if we do this in a separate PR.

The name will be set by the import in snowex_db. I have PR soon ready to highlight the new way and my current implementation will just use the pit_id or one given by an argument.

jomey added a commit to SnowEx/snowex_db that referenced this pull request Aug 8, 2025
Update the Point uploader to associate the measurement type with the point
record instead of the observation. This is a consequence of PR
SnowEx/snowexsql#195
@jomey

jomey commented Aug 8, 2025

Copy link
Copy Markdown
Member Author

@aaarendt - Updated the issue with a snapshot of a test run with the new structure
#194 (comment)

@jomey jomey merged commit c7c1540 into release-0.6.x Aug 8, 2025
9 checks passed
@jomey jomey deleted the measurement_type branch August 8, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants