Fresh off expanding the test suite for the GPR point importer, I see a need to remove the MeasurementType from the PointObservation and move that to the Points table.
To illustrate why, here a screenshot after importing a dataset that belongs to one GPR:
The original data looked like this:

I think we will make our lives a lot harder to answer a user question that would say: "Give me all the data that this GPR retrieved". Right now we would have to come up with some dicey logic to match on the first part of the name and date (or something), which feels very fragile.
One solution could be to simply move the measurement_type from the observation to the point, like we had initially some columns for. Then we could create two observation records per date (which this truly is) and easily fetch the associated points via relationship.
This seems a fairly easy change in the importer logic and makes searching a lot more straight forward.
Thoughts?
Related #192
Fresh off expanding the test suite for the GPR point importer, I see a need to remove the
MeasurementTypefrom thePointObservationand move that to thePointstable.To illustrate why, here a screenshot after importing a dataset that belongs to one GPR:
The original data looked like this:

I think we will make our lives a lot harder to answer a user question that would say: "Give me all the data that this GPR retrieved". Right now we would have to come up with some dicey logic to match on the first part of the name and date (or something), which feels very fragile.
One solution could be to simply move the
measurement_typefrom the observation to the point, like we had initially some columns for. Then we could create two observation records per date (which this truly is) and easily fetch the associated points via relationship.This seems a fairly easy change in the importer logic and makes searching a lot more straight forward.
Thoughts?
Related #192