Skip to content

v7: drop dead has_destats re-export; revert Hard DAE assertion #3479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 1 commit into from
Apr 20, 2026
+2 −4
Merged

v7: drop dead has_destats re-export; revert Hard DAE assertion #3479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/DiffEqBase/src/DiffEqBase.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ using SciMLBase: @def, DEIntegrator, AbstractDEProblem,
calculate_ensemble_errors, isconstant,
DEFAULT_REDUCTION, isautodifferentiable,
isadaptive, isdiscrete, has_syms, AbstractAnalyticalSolution,
RECOMPILE_BY_DEFAULT, wrap_sol, has_destats
RECOMPILE_BY_DEFAULT, wrap_sol

import SciMLBase: solve, init, step!, solve!, __init, __solve, update_coefficients!,
update_coefficients, isadaptive, wrapfun_oop, wrapfun_iip,
Expand Down
4 changes: 1 addition & 3 deletions test/regression/hard_dae.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,8 +300,6 @@ for prob in [prob1, prob2], alg in [simple_implicit_euler, alg_switch]
)
@test sol.retcode == ReturnCode.Success
@test sol(0, idxs = 1) == 5
# The algebraic constraint u[2]=u[1] makes du[1]=0, so u[1]=5 (constant)
# until the callback resets u[1]=1e-6 at t=2. After the reset u[1] recovers.
@test sol(2 - 2^-10, idxs = 1) ≈ 5.0 atol = 1.0e-4
@test abs(sol(2 - 2^-10, idxs = 1)) <= 1.0e-4
@test sol(4, idxs = 1) > 10
end
Loading