v7: drop dead has_destats re-export; revert Hard DAE assertion#3479
Merged
ChrisRackauckas merged 1 commit intoSciML:v7from Apr 20, 2026
Merged
Conversation
- `has_destats` was removed from SciMLBase v3 but DiffEqBase still re-exported it, producing `UndefVarError: has_destats` at precompile on the registered DiffEqBase used by Julia 1.10 (which ignores [sources]). The symbol is unused in this repo — drop it from the import list. - `test/regression/hard_dae.jl:305`: revert the assertion to `abs(sol(2-2^-10, idxs=1)) <= 1e-4`. The `hardstop!` DAE with mass matrix `Diagonal([1,0,1])` only makes `u[2]` algebraic; gravity (`du[3] = pg` for `t<2`) drives `u[1]` from 5 down, and the `y<=0` branch of the algebraic law pins `y≈0` well before `t=2`. The earlier `≈ 5.0` assertion was wrong. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>
ChrisRackauckas
added a commit
that referenced
this pull request
Apr 20, 2026
- `has_destats` was removed from SciMLBase v3 but DiffEqBase still re-exported it, producing `UndefVarError: has_destats` at precompile on the registered DiffEqBase used by Julia 1.10 (which ignores [sources]). The symbol is unused in this repo — drop it from the import list. - `test/regression/hard_dae.jl:305`: revert the assertion to `abs(sol(2-2^-10, idxs=1)) <= 1e-4`. The `hardstop!` DAE with mass matrix `Diagonal([1,0,1])` only makes `u[2]` algebraic; gravity (`du[3] = pg` for `t<2`) drives `u[1]` from 5 down, and the `y<=0` branch of the algebraic law pins `y≈0` well before `t=2`. The earlier `≈ 5.0` assertion was wrong. Co-authored-by: ChrisRackauckas-Claude <accounts@chrisrackauckas.com> Co-authored-by: Claude Opus 4 (1M context) <noreply@anthropic.com>
ChrisRackauckas
added a commit
that referenced
this pull request
Apr 21, 2026
- `has_destats` was removed from SciMLBase v3 but DiffEqBase still re-exported it, producing `UndefVarError: has_destats` at precompile on the registered DiffEqBase used by Julia 1.10 (which ignores [sources]). The symbol is unused in this repo — drop it from the import list. - `test/regression/hard_dae.jl:305`: revert the assertion to `abs(sol(2-2^-10, idxs=1)) <= 1e-4`. The `hardstop!` DAE with mass matrix `Diagonal([1,0,1])` only makes `u[2]` algebraic; gravity (`du[3] = pg` for `t<2`) drives `u[1]` from 5 down, and the `y<=0` branch of the algebraic law pins `y≈0` well before `t=2`. The earlier `≈ 5.0` assertion was wrong. Co-authored-by: ChrisRackauckas-Claude <accounts@chrisrackauckas.com> Co-authored-by: Claude Opus 4 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two targeted fixes for remaining non-lts real failures on v7 CI.
lib/DiffEqBase/src/DiffEqBase.jl: removehas_destatsfrom the SciMLBase import list. It was dropped from SciMLBase v3, is unused anywhere else in the repo, and currently emitsWARNING: Imported binding SciMLBase.has_destats was undeclared at import timeon 1.12 /UndefVarError: has_destats not definedon 1.10 (where[sources]is ignored).test/regression/hard_dae.jl: revert line 305 to@test abs(sol(2 - 2^-10, idxs = 1)) <= 1e-4. The assertion added in Fix FunctionMap DiscreteProblem import; correct Hard DAE test assertion #3469 (≈ 5.0) was incorrect. Thehardstop!DAE has mass matrixDiagonal([1,0,1])so onlyu[2]is algebraic; gravity (du[3] = pgfort<2) drivesu[1]down from 5, and oncey ≤ 0the algebraic branch pinsy ≈ 0well before the callback att=2. CI (Regression_I 1.11andRegression_I pre) showedsol(2-2^-10, idxs=1)evaluating to0.0/0.275…, not5.0— the original assertion was correct.Test plan
Regression_Ion 1 / 1.11 / pre passes🤖 Generated with Claude Code