Skip to content

Fix: price column sorting in offers table #2455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kanishka0411 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: price column sorting in offers table #2455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions frontend/src/components/BookTable/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,18 +386,38 @@ const BookTable = ({
};
}, []);

const getOrderPrice = useCallback(
(row: PublicOrder): number | null => {
const limits = federation.getLimits(row.coordinatorShortAlias);
const limitPrice = limits[row.currency.toString()]?.price;
if (!limitPrice) return null;
const premium = parseFloat(row.premium);
return limitPrice * (1 + premium / 100);
},
[federation],
);

const priceObj = useCallback(() => {
return {
field: 'price',
headerName: t('Price'),
type: 'number',
flex: 2,
sortComparator: (
_v1: number,
_v2: number,
p1: { api: { getRow: (id: number) => PublicOrder }; id: number },
p2: { api: { getRow: (id: number) => PublicOrder }; id: number },
) => {
const row1 = p1.api.getRow(p1.id);
const row2 = p2.api.getRow(p2.id);
const price1 = getOrderPrice(row1) ?? 0;
const price2 = getOrderPrice(row2) ?? 0;
return price1 - price2;
},
renderCell: (params: { row: PublicOrder }) => {
const currencyCode = String(currencyDict[params.row.currency.toString()]);
const limits = federation.getLimits(params.row.coordinatorShortAlias);
const premium = parseFloat(params.row.premium);
const limitPrice = limits[params.row.currency.toString()]?.price;
const price = (limitPrice ?? 1) * (1 + premium / 100);
const price = getOrderPrice(params.row);

return (
<div
Expand All @@ -406,7 +426,7 @@ const BookTable = ({
onOrderClicked(params.row.id, params.row.coordinatorShortAlias);
}}
>
{limitPrice ? (
{price ? (
`${pn(Math.round(price))} ${currencyCode}/BTC`
) : (
<Skeleton variant='rectangular' width={200} height={20} style={{ marginTop: 15 }} />
Expand Down
Loading