Fix: price column sorting in offers table#2455
Open
kanishka0411 wants to merge 1 commit into
Open
Conversation
juanfradb
approved these changes
May 11, 2026
juanfradb
left a comment
juanfradb
left a comment
There was a problem hiding this comment.
utACK bd0e1e3\n\nReviewed the one-file diff. The comparator now derives the sortable value from the same calculated price path used for rendering, instead of the raw field that is absent/null in row data.\n\nValidation run locally:\n- npx eslint src/components/BookTable/index.tsx\n- npm run build\n\nBuild completed with existing bundle-size warnings only. I did not run an end-to-end browser repro.
|
Small correction to my review text above: the missing raw field name is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2454
This PR introduces/refactors/...
Fixes price column sorting in the offers table. The displayed price was calculated on the fly but sorting used the raw field which was always null, so added a sort comparator that uses the actual calculated price.
Screen.Recording.2026-03-22.at.8.15.30.PM.mov
Checklist before merging
pip install pre-commit, thenpre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.