Skip to content

fix: BuilderTradeResponse deserialization bugs (#293, #294) #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JohnGalt017 wants to merge 3 commits into
base: main
Choose a base branch
from
+11 −8
Open

fix: BuilderTradeResponse deserialization bugs (#293, #294) #297

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b999159
fix: BuilderTradeResponse B256 fields -> Option<B256> for empty API v…
JohnGalt017 Mar 19, 2026
4885db7
fix: BuilderTradeResponse deserialization bugs
JohnGalt017 Mar 20, 2026
9c6a9cd
fix: remove redundant #[builder(default)] on Option fields (clippy)
JohnGalt017 Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions src/clob/types/response.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,12 +651,14 @@ pub struct BuilderApiKeyResponse {
pub struct BuilderTradeResponse {
pub id: String,
pub trade_type: String,
/// Hash of the taker order.
pub taker_order_hash: B256,
/// Address of the builder.
pub builder: Address,
/// The market condition ID.
pub market: B256,
/// Hash of the taker order (optional — may be empty for pending trades).
#[serde(default)]
pub taker_order_hash: Option<B256>,
Copy link
Copy Markdown

@cursor cursor Bot Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

serde(default) doesn't handle empty string B256 values

High Severity

#[serde(default)] only applies when the field is absent from the JSON — it does not handle the case where the API returns an empty string like "takerOrderHash": "". When the field is present but empty, B256 deserialization will still be attempted and fail. The same file already uses #[serde_as(as = "NoneAsEmptyString")] for identical Option<B256> patterns (e.g. condition_id, question_id) which correctly deserializes empty strings as None.

Additional Locations (2)
Fix in Cursor Fix in Web

/// Builder API key ID (UUID, not an Ethereum address).
pub builder: ApiKey,
/// The market condition ID (optional — may be empty in some API responses).
#[serde(default)]
pub market: Option<B256>,
pub asset_id: U256,
pub side: Side,
pub size: Decimal,
Expand All @@ -668,8 +670,9 @@ pub struct BuilderTradeResponse {
pub owner: ApiKey,
/// Address of the maker.
pub maker: Address,
/// On-chain transaction hash.
pub transaction_hash: B256,
/// On-chain transaction hash (optional — empty for unfilled/pending trades).
#[serde(default)]
pub transaction_hash: Option<B256>,
#[serde_as(as = "TimestampSeconds<String>")]
pub match_time: DateTime<Utc>,
pub bucket_index: u32,
Expand Down
Loading