fix: BuilderTradeResponse deserialization bugs (#293, #294)

[JohnGalt017]

Summary

Fixes two deserialization bugs in BuilderTradeResponse:

• builder field (Address → ApiKey): The /builder/trades API returns a UUID builder key ID (e.g. "019b618b-4a91-7dd9-a4c9-aadfbcbd5b95"), not an Ethereum address. Deserialization fails with invalid string length. The TypeScript SDK correctly types this as string. Fixes BuilderTradeResponse: builder field typed as Address but API returns UUID #294.

• B256 fields (taker_order_hash, market, transaction_hash → Option<B256>): The API can return empty strings for pending/unfilled trades. Added #[serde(default)] + #[builder(default)] to handle gracefully. Fixes BuilderTradeResponse: B256 fields fail to deserialize when API returns empty/short strings #293.

Changes

• src/clob/types/response.rs: builder: Address → builder: ApiKey, three B256 fields → Option<B256>

Verified

Tested against live /builder/trades API responses. Both issues confirmed reproducible with actual API JSON.

---

Note

Medium Risk
Medium risk because it changes public response types (builder and several hash fields) and may require downstream code updates, though the changes are narrowly scoped to deserialization behavior.

Overview
Updates BuilderTradeResponse deserialization to match real /builder/trades responses. The builder field is retyped from an Ethereum Address to an ApiKey (UUID), and taker_order_hash, market, and transaction_hash are made optional with #[serde(default)] to gracefully handle empty strings for pending/unfilled trades.

^{Written by Cursor Bugbot for commit 9c6a9cd. This will update automatically on new commits. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

[cursor]

serde(default) doesn't handle empty string B256 values

High Severity

#[serde(default)] only applies when the field is absent from the JSON — it does not handle the case where the API returns an empty string like "takerOrderHash": "". When the field is present but empty, B256 deserialization will still be attempted and fail. The same file already uses #[serde_as(as = "NoneAsEmptyString")] for identical Option<B256> patterns (e.g. condition_id, question_id) which correctly deserializes empty strings as None.

Additional Locations (2)

• src/clob/types/response.rs#L659-L663
• src/clob/types/response.rs#L674-L678

 

[chaz-polymarket]

just have to fix the tests