Skip to content

Generate new Ids for BagPart embedded elements #19165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hishamco wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Generate new Ids for BagPart embedded elements #19165

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7c74b71
Generate new Ids for BagPart embedded elements
hishamco Apr 17, 2026
bf4ea71
Generate new id's for cloned widgets
hishamco Apr 23, 2026
c99e0cd
Generate new id's for taxonomy terms
hishamco Apr 23, 2026
90c6c46
Invoke CloningAsync inside BagPartDisplayDriver
hishamco Apr 23, 2026
180447c
Revert AutoroutePartHandler changes
hishamco Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OrchardCore.Modules/OrchardCore.Autoroute/Handlers/AutoroutePartHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ public override async Task UpdatedAsync(UpdateContentContext context, AutorouteP
await GenerateContainedPathsFromPatternAsync(context.ContentItem, part);
}

public override async Task CloningAsync(CloneContentContext context, AutoroutePart part)
public override async Task ClonedAsync(CloneContentContext context, AutoroutePart part)
Copy link
Copy Markdown
Member Author

@hishamco hishamco Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to change the OC.Flow startup order instead

Copy link
Copy Markdown
Member

@gvkries gvkries Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think is better to keep this in Cloning and change the startup order.

{
if (!context.CloneContentItem.TryGet<AutoroutePart>(out var clonedPart))
{
Expand Down
20 changes: 20 additions & 0 deletions src/OrchardCore.Modules/OrchardCore.Flows/Handlers/BagPartHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System.Text.Json.Nodes;
using OrchardCore.ContentManagement;
using OrchardCore.ContentManagement.Handlers;
using OrchardCore.ContentManagement.Routing;
using OrchardCore.Flows.Models;
Expand All @@ -7,6 +8,25 @@ namespace OrchardCore.Flows.Handlers;

public class BagPartHandler : ContentPartHandler<BagPart>
{
private readonly IContentItemIdGenerator _idGenerator;

public BagPartHandler(IContentItemIdGenerator idGenerator) => _idGenerator = idGenerator;

public override Task CloningAsync(CloneContentContext context, BagPart part)
{
if (context.CloneContentItem.TryGet<BagPart>(out var clonedBagPart))
{
foreach (var contentItem in clonedBagPart.ContentItems)
{
contentItem.ContentItemId = _idGenerator.GenerateUniqueId(contentItem);
}

clonedBagPart.Apply();
}

return Task.CompletedTask;
}

public override Task GetContentItemAspectAsync(ContentItemAspectContext context, BagPart part)
{
return context.ForAsync<ContainedContentItemsAspect>(aspect =>
Expand Down
Loading