Generate new Ids for BagPart embedded elements#19165
Conversation
| } | ||
|
|
||
| public override async Task CloningAsync(CloneContentContext context, AutoroutePart part) | ||
| public override async Task ClonedAsync(CloneContentContext context, AutoroutePart part) |
There was a problem hiding this comment.
We might need to change the OC.Flow startup order instead
There was a problem hiding this comment.
Yes, I think is better to keep this in Cloning and change the startup order.
|
Did you consider the notes from this comment: #8185 (comment)? |
A lot of things :) But I will revise it one more time |
|
Note for myself, if the PR hasn't progressed in two weeks, let's close it, I fear it will get idle as this is more complicated than expected. |
|
Maybe we should do this for v4, to have more time understanding possible side effects. |
| var cloneContentContext = new CloneContentContext(existingContentItem, contentItem); | ||
|
|
||
| await _contentHandlers.InvokeAsync((handler, context) => handler.CloningAsync(context), cloneContentContext, _logger); |
There was a problem hiding this comment.
Not sure if we can do this, it seems to contradict what is commented above (IDs are expected to be kept).
3 participants
Fixes #8185