Support GECON WELL workover procedure. #7100
Conversation
GitPaean
added
the
manual:enhancement
GitPaean
force-pushed
the
support_GECON_WELL
branch
2 times, most recently
from
76c6d14 to
8005df8
Compare
|
jenkins build this opm-common=5191 please |
There was a problem hiding this comment.
Pull request overview
This PR adds support for the GECON keyword’s item 7 workover procedure WELL by implementing logic to identify the worst offending producer (based on the violated ratio) within a group hierarchy and close that well, instead of throwing “not implemented”.
Changes:
- Extend
GroupEconomicLimitsCheckerratio checks to return structured ratio-violation details and implementGECON(WORKOVER)=WELLby closing the worst offending producer well. - Update
BlackoilWellModelGeneric::checkGEconLimits()to route ratio violations through the new details-based API. - Update keyword support validation to accept
GECON(WORKOVER)=WELL.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| opm/simulators/wells/GroupEconomicLimitsChecker.hpp | Adds ratio-violation types/details and new workover-related APIs/helpers. |
| opm/simulators/wells/GroupEconomicLimitsChecker.cpp | Implements WELL workover procedure: find worst offending producer ratio across MPI ranks and close that well. |
| opm/simulators/wells/BlackoilWellModelGeneric.cpp | Switches GECON ratio checking to the new ratioViolation() + doWorkOver(details) flow. |
| opm/simulators/utils/PartiallySupportedFlowKeywords.cpp | Marks GECON(WORKOVER) as supporting NONE and WELL. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GitPaean
force-pushed
the
support_GECON_WELL
branch
from
e370a8c to
3d676aa
Compare
|
jenkins build this opm-common=5191 please The jenkins results is here. https://ci.opm-project.org/job/opm-simulators-PR-builder/10010/ it is green. |
|
The messaging might be too long, 
Will break the line after the jenkins finished. |
|
not related to this PR, somehow we give non-zero values for the WGPRH, although there is not historical keywords specified. 
|
Obviously, there is some bug or inconsistency in the reference simulator, they choose to have zero -RH summary output, but non-zero -TH summary output. The black line is the reference simulator, the green line is flow. But the one below is after I tried to zero-out the -RH output. |
GitPaean
force-pushed
the
support_GECON_WELL
branch
from
3d676aa to
2b8dd46
Compare
it looks the following way now. 
|
|
I added a new regression test, so the new jenkins test will fail because of that. |
|
jenkins build this please |
|
jenkins build this opm-common=5191 please |
|
mind the new warnings. |
Thanks. They are fixed now. |
|
jenkins build this opm-common=5191 please |
|
jenkins build this opm-common=5191 please |
The PR implement the item 7 of GECON keyword set to be WELL workover procedure.
It depends on OPM/opm-common#5191 .