Msw refactoring after thermal msw#7043
Draft
GitPaean wants to merge 11 commits into
Draft
Conversation
including adding tempearture as the primary variable for the MSW. to calculate the enthalpy, for each segment, we generate a SegmentFluidState.
to test the thermal equation solving for MSW
for thermal cases in MultisegmentWell.
instead of using 0, which is not physical
and using the calculation in createSegmentFluidState to calculate the surface volume of the segments to reduce duplicated calculation.
remains to be cleaned up.
GitPaean
added
the
manual:irrelevant
Member
Author
|
jenkins build this opm-tests=1519 please |
Member
Author
|
jenkins build this opm-tests=1519 failure_report please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the PR #6816, we create a FluidState for each segment.
This PR aims at reusing of the FluidState in the calculating the surface volume of the segment and calculate the fluid properties.