Skip to content

adding the member volume_ratio_ for BlackOilFluidState#5087

Closed
GitPaean wants to merge 1 commit into
OPM:masterfrom
GitPaean:volume_ratio_fluid_state
Closed

adding the member volume_ratio_ for BlackOilFluidState#5087
GitPaean wants to merge 1 commit into
OPM:masterfrom
GitPaean:volume_ratio_fluid_state

Conversation

@GitPaean
Copy link
Copy Markdown
Member

@GitPaean GitPaean added the manual:irrelevant This PR is a minor fix and should not appear in the manual label Mar 20, 2026
@GitPaean
Copy link
Copy Markdown
Member Author

jenkins build this opm-simulators=6957 please

@GitPaean GitPaean force-pushed the volume_ratio_fluid_state branch from 467c9e9 to 772fcb0 Compare March 23, 2026 14:59
@GitPaean
Copy link
Copy Markdown
Member Author

jenkins build this opm-simulators=6957 failure_report please

@GitPaean GitPaean force-pushed the volume_ratio_fluid_state branch from 772fcb0 to b82bcd3 Compare March 24, 2026 10:27
@GitPaean
Copy link
Copy Markdown
Member Author

jenkins build this opm-simulators=6957 failure_report please

@GitPaean
Copy link
Copy Markdown
Member Author

This PR will also makes OPM/opm-simulators#7043 easier.

@GitPaean GitPaean force-pushed the volume_ratio_fluid_state branch from b82bcd3 to 4970d9e Compare May 12, 2026 09:20
@GitPaean
Copy link
Copy Markdown
Member Author

But since it is only used in the wellbore calculation. Maybe it is not good to add extra burden to the whole system, mostly the fluid state for the reservoir side.

@atgeirr
Copy link
Copy Markdown
Member

atgeirr commented May 12, 2026

Maybe it is not good to add extra burden to the whole system, mostly the fluid state for the reservoir side.

I agree with that, increasing the size of the fluid state for well usage only is not good. Can you instead use a separate class for the well usage, that contains both this fluid state and the extra data you need?

@GitPaean
Copy link
Copy Markdown
Member Author

Maybe it is not good to add extra burden to the whole system, mostly the fluid state for the reservoir side.

I agree with that, increasing the size of the fluid state for well usage only is not good. Can you instead use a separate class for the well usage, that contains both this fluid state and the extra data you need?

That is a very helpful suggestion. I am closing the PR now based on the discussion.

@GitPaean GitPaean closed this May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manual:irrelevant This PR is a minor fix and should not appear in the manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants