Detect rule types/v21#8928
Closed
victorjulien wants to merge 4 commits into
Closed
Conversation
Instead of using flags to indicate a rule type, use an explicit `type` field. Define the following fields: - SIG_TYPE_IPONLY: sig meets IP-only criteria and is handled by the IP-only engine. - SIG_TYPE_PDONLY: sig inspects protocol detection results only. - SIG_TYPE_DEONLY: sig inspects decoder events only. - SIG_TYPE_PKT: sig is inspected per packet. - SIG_TYPE_PKT_STREAM: sig is inspected against either packet payload or stream payload. - SIG_TYPE_STREAM: sig is inspected against the reassembled stream - SIG_TYPE_APPLAYER: sig is inspected against an app-layer property, but not against a tx engine. - SIG_TYPE_APP_TX: sig is inspected the tx aware inspection engine(s). Ticket: OISF#6085.
Per rule type record properties of the type.
Example output:
"type": "ip_only",
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8928 +/- ##
=======================================
Coverage 82.34% 82.34%
=======================================
Files 969 969
Lines 273336 273431 +95
=======================================
+ Hits 225090 225169 +79
- Misses 48246 48262 +16
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 14072 |
This was referenced May 26, 2023
Closed
Closed
Merged
Member
Author
|
Merged in #8945 after minor fixups. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SV_BRANCH=pr/1219
replaces #8906