Skip to content

tests: add rule types check#1219

Closed
victorjulien wants to merge 1 commit into
OISF:masterfrom
victorjulien:rule-types/v3
Closed

tests: add rule types check#1219
victorjulien wants to merge 1 commit into
OISF:masterfrom
victorjulien:rule-types/v3

Conversation

@victorjulien
Copy link
Copy Markdown
Member

@victorjulien victorjulien commented May 25, 2023

Replaces #1213

@victorjulien victorjulien added the requires suricata pr Depends on a PR in Suricata label May 25, 2023
@inashivb inashivb mentioned this pull request Jun 9, 2023
Closed
@catenacyber
Copy link
Copy Markdown
Collaborator

catenacyber commented Jun 9, 2023

OISF/suricata#8928 was merged
Should these tests pass ?

@catenacyber catenacyber added tests pass These new tests should pass and removed requires suricata pr Depends on a PR in Suricata labels Jun 20, 2023
@catenacyber
Copy link
Copy Markdown
Collaborator

catenacyber commented Jun 20, 2023

Tests pass now on master

@jasonish jasonish mentioned this pull request Jun 20, 2023
Merged
@jasonish
Copy link
Copy Markdown
Member

jasonish commented Jun 20, 2023

Merged via #1263. Thanks!

@jasonish jasonish closed this Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

tests pass These new tests should pass

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@victorjulien @catenacyber @jasonish