http: logs custom headers in a subobject#8672
Closed
catenacyber wants to merge 1 commit into
Closed
Conversation
This subobject is request_headers or response_headers This especially avoids json keys collisions. Ticket: OISF#5320 Also fixes typo referrer/referer
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8672 +/- ##
==========================================
+ Coverage 81.78% 81.87% +0.08%
==========================================
Files 968 968
Lines 279008 279000 -8
==========================================
+ Hits 228195 228424 +229
+ Misses 50813 50576 -237
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 12996 |
jasonish
reviewed
Apr 11, 2023
| size_t n = htp_table_size(headers); | ||
| JsonBuilderMark mark = { 0, 0, 0 }; | ||
| jb_get_mark(js, &mark); | ||
| bool arrayHasOneElem = false; |
Member
There was a problem hiding this comment.
Not really our variable naming convention.
Contributor
Author
There was a problem hiding this comment.
Replacing with what I found here https://redmine.openinfosecfoundation.org/projects/suricata/wiki/Coding_Style#Names
Contributor
Author
|
Replaced by #8714 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5320
Describe changes:
To avoid collisions, for instance for
content_rangeWith this PR, the output will be
instead of
response_headersis already used with the config optiondump-all-headerssuricata-verify-pr: 1026
Replaces #8268 with rebase fixing compilation (
SCLogWarningusing string directly)