Skip to content

http: logs custom headers in a subobject#8669

Closed
catenacyber wants to merge 1 commit into
OISF:masterfrom
catenacyber:http-customlog-5320-v5
Closed

http: logs custom headers in a subobject#8669
catenacyber wants to merge 1 commit into
OISF:masterfrom
catenacyber:http-customlog-5320-v5

Conversation

@catenacyber
Copy link
Copy Markdown
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5320

Describe changes:

  • http: logs custom headers in a subobject

To avoid collisions, for instance for content_range

With this PR, the output will be

    "content_range": {
      "raw": "bytes 10-20/69",
      "start": 10,
      "end": 20,
      "size": 69
    },
    "response_headers": [
      {
        "name": "Content-Range",
        "value": "bytes 10-20/69"
      }
    ]

instead of

    "content_range": {
      "raw": "bytes 10-20/69",
      "start": 10,
      "end": 20,
      "size": 69
    },
   "content_range": "bytes 10-20/69"

response_headers is already used with the config option dump-all-headers

suricata-verify-pr: 1026

Replaces #8264 with rebase to get attention

This subobject is request_headers or response_headers

This especially avoids json keys collisions.

Ticket: OISF#5320

Also fixes typo referrer/referer
@suricata-qa
Copy link
Copy Markdown

WARNING:

field baseline test %
build_asan

Pipeline 12980

@catenacyber
Copy link
Copy Markdown
Contributor Author

Replaced by #8672

@catenacyber catenacyber closed this Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants