feat: integrate rust daemon behind a flag#719
Open
CougarTasker wants to merge 1 commit into
Open
Conversation
This was referenced Jun 17, 2026
CougarTasker
added
the
version:minor
Contributor
|
Consider updating changelogs/pending-changelog.md with a summary of this change for the release notes. This is optional and non-blocking. |
CougarTasker
force-pushed
the
feat/rust-daemon-setup
branch
from
b3a4d47 to
eb7c452
Compare
CougarTasker
force-pushed
the
feat/rust-daemon-integration
branch
from
ac12415 to
733fc8f
Compare
CougarTasker
changed the title
CougarTasker
force-pushed
the
feat/rust-daemon-integration
branch
from
733fc8f to
d306696
Compare
CougarTasker
force-pushed
the
feat/rust-daemon-setup
branch
from
eb7c452 to
4329915
Compare
CougarTasker
force-pushed
the
feat/rust-daemon-integration
branch
from
d306696 to
4eef1da
Compare
CougarTasker
force-pushed
the
feat/rust-daemon-setup
branch
from
4329915 to
9b03330
Compare
CougarTasker
force-pushed
the
feat/rust-daemon-integration
branch
from
4eef1da to
51b4e8e
Compare
CougarTasker
force-pushed
the
feat/rust-daemon-setup
branch
from
9b03330 to
aeb78d2
Compare
CougarTasker
force-pushed
the
feat/rust-daemon-integration
branch
from
51b4e8e to
04f8f1b
Compare
CougarTasker
force-pushed
the
feat/rust-daemon-setup
branch
from
aeb78d2 to
e3bf235
Compare
CougarTasker
force-pushed
the
feat/rust-daemon-integration
branch
2 times, most recently
from
56da482 to
2cde023
Compare
CougarTasker
force-pushed
the
feat/rust-daemon-setup
branch
from
e3bf235 to
5e506c1
Compare
CougarTasker
force-pushed
the
feat/rust-daemon-integration
branch
from
2cde023 to
ead7362
Compare
CougarTasker
force-pushed
the
feat/rust-daemon-setup
branch
from
5e506c1 to
96206d2
Compare
| _has_validated_version = False | ||
| _active_robot: Robot | None = None | ||
| _active_dataset_id: str | None = None | ||
| _active_dataset: "Dataset | None" = None |
Contributor
There was a problem hiding this comment.
do we need active_dataset_id if we can pull it off dataset now?
Member
Author
There was a problem hiding this comment.
No, technically not but it keeps the diff much smaller
|
|
||
|
|
||
| def _smoke_validate_joint_values(joint_data: dict[str, float]) -> None: | ||
| """Smoke-test that a sample of joint values are floats. |
Contributor
There was a problem hiding this comment.
Add context to this pydoc about why we do this.
| def prepare_recording_stopped(self) -> tuple[ProducerChannel, int]: | ||
| """Mark the producer channel as stopping and return it.""" | ||
| producer_channel = self.get_producer_channel() | ||
| def _on_producer_channel_ready(self) -> None: |
Contributor
There was a problem hiding this comment.
empty function?
| # Serialize metadata and frame to bytes | ||
| # Frame is sent as raw numpy bytes with metadata as JSON header | ||
| frame_source = ( | ||
| frame if frame.flags.c_contiguous else np.ascontiguousarray(frame) |
| return | ||
| self.recording_robot_instances.pop(instance_key, None) | ||
| self._cancel_recording_timers(recording_id) | ||
| # Note: the native producer stop is driven by the recording context |
Contributor
There was a problem hiding this comment.
very verbose comment
damonhayhurst-neuraco
approved these changes
Jun 26, 2026
CougarTasker
force-pushed
the
feat/rust-daemon-setup
branch
from
96206d2 to
875af2e
Compare
CougarTasker
force-pushed
the
feat/rust-daemon-integration
branch
from
ead7362 to
4014df2
Compare
CougarTasker
force-pushed
the
feat/rust-daemon-setup
branch
from
875af2e to
8d47d0a
Compare
CougarTasker
force-pushed
the
feat/rust-daemon-integration
branch
from
4014df2 to
7f3e237
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
NCD_RUST_DAEMONis truthy; the Python daemon stays the default, so behaviour is unchanged out of the box.setup.py,MANIFEST.in,build_wheel_artefacts.sh) and adds thebuild-wheelsCI workflow.Bugfixes
Items
Related PRs