feat: scaffold the rust data daemon#718
Merged
Merged
Conversation
This was referenced Jun 17, 2026
b3a4d47 to
eb7c452
Compare
9b03330 to
aeb78d2
Compare
e3bf235 to
5e506c1
Compare
Contributor
|
LGTM! One suggestion though would be to improve unit test coverage around ipc communications in the data_daemon crate. Here's an overall coverage report Coverage ReportTotals: Functions 70.49% (829/1176) · Lines 67.83% (8312/12255) · Regions 69.30% (12608/18193)
|
5e506c1 to
96206d2
Compare
CougarTasker
commented
Jun 25, 2026
CougarTasker
left a comment
Member
Author
There was a problem hiding this comment.
suggestion: naming of coodinators and handles doesn't suggest a relationship
Disscussed offline will rename Handle -> Handler to disguish
96206d2 to
875af2e
Compare
Member
Author
discussed offline will rename where it makes sense |
875af2e to
8d47d0a
Compare
damonhayhurst-neuraco
approved these changes
Jun 26, 2026
8d47d0a to
f5c5b52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
rust/— thedata_daemonbinary plus thedata_daemon_ipcanddata_daemon_producercrates.rust-data-daemonCI workflow (cargo fmt / clippy / test / build / doc) and thecargo fmt/clippypre-commit hooks.Bugfixes
Items
Related PRs