Skip to content

feat: honour ONTAP_TIMEOUT env var in OntapClient.from_env() #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
algojogacor wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −1
Open

feat: honour ONTAP_TIMEOUT env var in OntapClient.from_env() #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions python/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,14 @@ set -a && source cluster.env && set +a
> SSL verification is disabled by default to support environments that use
> self-signed certificates. We recommend setting `ONTAP_VERIFY_SSL=true`
> once CA-signed certificates are in place.
>
> The request timeout defaults to 30 seconds. Set `ONTAP_TIMEOUT` (in seconds)
> to adjust this for your environment:
>
> ```bash
> export ONTAP_TIMEOUT=10 # fail fast in CI
> export ONTAP_TIMEOUT=60 # allow extra time for slow clusters
> ```

---

Expand Down
6 changes: 5 additions & 1 deletion python/ontap_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,8 @@ def from_env(cls) -> OntapClient:

Optional (with defaults):
``ONTAP_USER`` (default ``admin``),
``ONTAP_VERIFY_SSL`` (default ``false``)
``ONTAP_VERIFY_SSL`` (default ``false``),
``ONTAP_TIMEOUT`` (default ``30`` seconds)
"""
host = os.environ.get("ONTAP_HOST", "")
if not host:
Expand All @@ -121,11 +122,14 @@ def from_env(cls) -> OntapClient:
logger.error("ONTAP_PASS environment variable is required")
sys.exit(1)

timeout = int(os.environ.get("ONTAP_TIMEOUT", str(_DEFAULT_TIMEOUT)))

return cls(
host=host,
username=os.environ.get("ONTAP_USER", "admin"),
password=password,
verify_ssl=os.environ.get("ONTAP_VERIFY_SSL", "false").lower() == "true",
timeout=timeout,
)

# -- HTTP helpers -------------------------------------------------------
Expand Down
Loading