feat: honour ONTAP_TIMEOUT env var in OntapClient.from_env()#40
Open
algojogacor wants to merge 1 commit into
Open
feat: honour ONTAP_TIMEOUT env var in OntapClient.from_env()#40algojogacor wants to merge 1 commit into
algojogacor wants to merge 1 commit into
Conversation
Reads optional ONTAP_TIMEOUT environment variable (defaults to 30s) and passes it as the timeout argument to the OntapClient constructor. - Updated from_env() classmethod to read ONTAP_TIMEOUT - Updated docstring to document the new env var - Updated python/README.md with ONTAP_TIMEOUT usage examples Closes NetApp#35
|
Test Report missing or unfilled. This PR touches This is a soft gate - your CI checks are unaffected - but reviewers will not approve until the report is filled in. |
There was a problem hiding this comment.
Thanks for your first PR to Pace — welcome aboard.
Quick orientation:
- CI runs in ~2 minutes. If anything fails, check the Actions tab — most failures have a one-line fix in
docs/troubleshooting.md. - If your PR touches
python/,ansible/, orterraform/, you'll be asked for a Test Report. It's worth the effort — reviewers rely on it. - Make sure the NetApp CCLA is on file before review.
- Stuck? Comment on this PR and a maintainer will jump in. We aim to respond as soon as possible.
For background, see CONTRIBUTING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Honour
ONTAP_TIMEOUTenvironment variable inOntapClient.from_env(), allowing users to configure the request timeout without modifying code.Changes
python/ontap_client.py:from_env()now reads optionalONTAP_TIMEOUTenv var (defaults to 30s) and passes it astimeout=to the constructor. Docstring updated accordingly.python/README.md: AddedONTAP_TIMEOUTdocumentation with usage examples for CI and slow clusters.Testing
Closes #35