Skip to content

refactor: random cleanups from the opt_cylcle_I-branch #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romanc merged 3 commits into from
Jul 1, 2026
Merged

refactor: random cleanups from the opt_cylcle_I-branch #494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
631e3ce
Make "dace" import non-ambiguous + cleanup
romanc Jun 25, 2026
139ad98
Push `matplolib` import into the plotting function
FlorianDeconinck Jun 23, 2026
195ef57
just a space missing in the warning message
romanc Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions ndsl/dsl/stencil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
from collections.abc import Callable, Iterable, Mapping, Sequence
from typing import Any, cast

import dace
import numpy as np
from dace.config import Config as DaceConfig
from gt4py.cartesian import config as gt_config
from gt4py.cartesian import definitions as gt_definitions
from gt4py.cartesian import gtscript
Expand Down Expand Up @@ -321,7 +321,7 @@ def __init__(
BackendFramework.DACE
== self.stencil_config.compilation_config.backend.framework
):
dace.Config.set(
DaceConfig.set(
"default_build_folder",
value="{gt_root}/{gt_cache}/dacecache".format(
gt_root=gt_config.cache_settings["root_path"],
Expand Down Expand Up @@ -881,23 +881,27 @@ def _origin_from_dims(self, dims: Iterable[str]) -> list[int]:
return_origin.append(self.origin[1])
elif dim in K_DIMS:
return_origin.append(self.origin[2])
else:
raise ValueError(f"Unknown dimension '{dim}'.")
return return_origin

def _domain_from_dims(self, dimensions: Iterable[str]) -> list[int]:
result = []
for dimension in dimensions:
if dimension == I_DIM:
result.append(self.domain[0])
if dimension == I_INTERFACE_DIM:
elif dimension == I_INTERFACE_DIM:
result.append(self.domain[0] + 1)
if dimension == J_DIM:
elif dimension == J_DIM:
result.append(self.domain[1])
if dimension == J_INTERFACE_DIM:
elif dimension == J_INTERFACE_DIM:
result.append(self.domain[1] + 1)
if dimension == K_DIM:
elif dimension == K_DIM:
result.append(self.domain[2])
if dimension == K_INTERFACE_DIM:
elif dimension == K_INTERFACE_DIM:
result.append(self.domain[2] + 1)
else:
raise ValueError(f"Unknown dimension '{dimension}'.")
return result

def get_shape(
Expand Down
5 changes: 3 additions & 2 deletions ndsl/quantity/quantity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
from typing import Any, cast

import dace
import matplotlib.pyplot as plt
import numpy as np
import xarray as xr
from gt4py import storage as gt_storage
Expand Down Expand Up @@ -287,7 +286,7 @@ def field(self) -> np.ndarray | cupy.ndarray:
def data(self) -> np.ndarray | cupy.ndarray:
"""The underlying array of data"""
warnings.warn(
"Quantity.data accessor is now deprecated. Use a slicing operation directly on"
"Quantity.data accessor is now deprecated. Use a slicing operation directly on "
"the quantity, e.g. `my_quantity[:]` instead of `my_quantity.data[:]`",
category=UserWarning,
stacklevel=2,
Expand Down Expand Up @@ -459,6 +458,8 @@ def transpose(
return transposed

def plot_k_level(self, k_index: int = 0) -> None:
import matplotlib.pyplot as plt

field = self._data
plt.xlabel("I")
plt.ylabel("J")
Expand Down