refactor: random cleanups from the opt_cylcle_I-branch#494
Merged
Conversation
Because we have a "dace/" directory in `ndsl/dsl`, the previous import could be resolved as a local import. If that happened (depending on import order), then the DaCe's `Config` object would not be found there. Resolved by importing `Config` from `dace.config`, which is unambiguous to resolve. In addition, this PR adds light cleanup when selecting origin/domain form dims.
romanc
changed the title
opt_cylcle_I-branch
twicki
approved these changes
Jul 1, 2026
twicki
left a comment
twicki
left a comment
Collaborator
There was a problem hiding this comment.
These all make sense, thanks for extracting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR combines
daceimport in stencil modulematplotlibwhich are all technically unrelated to the
opt_cycle_I-branch but in there nevertheless. This PR is part of building back the "opt_cycle_I"-branch, i.e. trying to get #465 into a smaller changeset.How has this been tested?
Assumed to be covered in one way or another by current tests. At least, it worked on the
opt_cycle_I-branch when running integrated in GEOS.Checklist