Skip to content

LibWeb: Hide unrelated popovers when showing popovers#3537

Merged
tcl3 merged 2 commits intoLadybirdBrowser:masterfrom
Gingeh:popover-stuff
Feb 16, 2025
Merged

LibWeb: Hide unrelated popovers when showing popovers#3537
tcl3 merged 2 commits intoLadybirdBrowser:masterfrom
Gingeh:popover-stuff

Conversation

Prevents the layout engine from crashing.
(and unlocks ~200 new subtests)
Comment thread Libraries/LibWeb/HTML/HTMLDialogElement.cpp
Comment thread Libraries/LibWeb/HTML/HTMLDialogElement.cpp Outdated
Comment thread Libraries/LibWeb/HTML/HTMLElement.cpp Outdated
Comment thread Libraries/LibWeb/HTML/HTMLElement.cpp Outdated
Also hides decendant popovers when hiding.
Also hides unrelated popovers when showing dialogs.
@tcl3 tcl3 merged commit 91e4fb2 into LadybirdBrowser:master Feb 16, 2025
@Gingeh Gingeh deleted the popover-stuff branch February 16, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants