LibWeb: Hide unrelated popovers when showing popovers#3537
Merged
tcl3 merged 2 commits intoLadybirdBrowser:masterfrom Feb 16, 2025
Merged
LibWeb: Hide unrelated popovers when showing popovers#3537tcl3 merged 2 commits intoLadybirdBrowser:masterfrom
tcl3 merged 2 commits intoLadybirdBrowser:masterfrom
Conversation
Prevents the layout engine from crashing. (and unlocks ~200 new subtests)
tcl3
reviewed
Feb 13, 2025
Also hides decendant popovers when hiding. Also hides unrelated popovers when showing dialogs.
904a38a to
b93256e
Compare
tcl3
approved these changes
Feb 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also hides decendant popovers when hiding.
Also hides unrelated popovers when showing dialogs.
This PR is affected by the following spec bugs, each instance of ad-hoc behaviour is noted and referenced: