LibWeb: Hide unrelated popovers when showing popovers

Also hides decendant popovers when hiding.
Also hides unrelated popovers when showing dialogs.

Author: Gingeh

Libraries/LibWeb/DOM/Document.cpp

@@ -574,6 +574,8 @@ void Document::visit_edges(Cell::Visitor& visitor)
 
     visitor.visit(m_top_layer_elements);
     visitor.visit(m_top_layer_pending_removals);
+    visitor.visit(m_showing_auto_popover_list);
+    visitor.visit(m_showing_hint_popover_list);
     visitor.visit(m_console_client);
     visitor.visit(m_editing_host_manager);
     visitor.visit(m_local_storage_holder);

Libraries/LibWeb/DOM/Document.h

@@ -712,6 +712,13 @@ class Document
 
     OrderedHashTable<GC::Ref<Element>> const& top_layer_elements() const { return m_top_layer_elements; }
 
+    // AD-HOC: These lists are managed dynamically instead of being generated as needed.
+    // Spec issue: https://github.com/whatwg/html/issues/11007
+    Vector<GC::Ref<HTML::HTMLElement>>& showing_auto_popover_list() { return m_showing_auto_popover_list; }
+    Vector<GC::Ref<HTML::HTMLElement>>& showing_hint_popover_list() { return m_showing_hint_popover_list; }
+    Vector<GC::Ref<HTML::HTMLElement>> const& showing_auto_popover_list() const { return m_showing_auto_popover_list; }
+    Vector<GC::Ref<HTML::HTMLElement>> const& showing_hint_popover_list() const { return m_showing_hint_popover_list; }
+
     size_t transition_generation() const { return m_transition_generation; }
 
     // Does document represent an embedded svg img
@@ -1101,6 +1108,9 @@ class Document
     OrderedHashTable<GC::Ref<Element>> m_top_layer_elements;
     OrderedHashTable<GC::Ref<Element>> m_top_layer_pending_removals;
 
+    Vector<GC::Ref<HTML::HTMLElement>> m_showing_auto_popover_list;
+    Vector<GC::Ref<HTML::HTMLElement>> m_showing_hint_popover_list;
+
     // https://dom.spec.whatwg.org/#document-allow-declarative-shadow-roots
     bool m_allow_declarative_shadow_roots { false };
 

Libraries/LibWeb/HTML/HTMLDialogElement.cpp

@@ -135,11 +135,23 @@ WebIDL::ExceptionOr<void> HTMLDialogElement::show()
     // 9. Set the dialog close watcher with this.
     set_close_watcher();
     // FIXME: 10. Set this's previously focused element to the focused element.
-    // FIXME: 11. Let document be this's node document.
-    // FIXME: 12. Let hideUntil be the result of running topmost popover ancestor given this, document's showing hint popover list, null, and false.
-    // FIXME: 13. If hideUntil is null, then set hideUntil to the result of running topmost popover ancestor given this, document's showing auto popover list, null, and false.
-    // FIXME: 14. If hideUntil is null, then set hideUntil to document.
-    // FIXME: 15. Run hide all popovers until given hideUntil, false, and true.
+
+    // 11. Let document be this's node document.
+    auto document = m_document;
+
+    // 12. Let hideUntil be the result of running topmost popover ancestor given this, document's showing hint popover list, null, and false.
+    Variant<GC::Ptr<HTMLElement>, GC::Ptr<DOM::Document>> hide_until = topmost_popover_ancestor(this, document->showing_hint_popover_list(), nullptr, IsPopover::No);
+
+    // 13. If hideUntil is null, then set hideUntil to the result of running topmost popover ancestor given this, document's showing auto popover list, null, and false.
+    if (!hide_until.get<GC::Ptr<HTMLElement>>())
+        hide_until = topmost_popover_ancestor(this, document->showing_auto_popover_list(), nullptr, IsPopover::No);
+
+    // 14. If hideUntil is null, then set hideUntil to document.
+    if (!hide_until.get<GC::Ptr<HTMLElement>>())
+        hide_until = document;
+
+    // 15. Run hide all popovers until given hideUntil, false, and true.
+    hide_all_popovers_until(hide_until, FocusPreviousElement::No, FireEvents::Yes);
 
     // 16. Run the dialog focusing steps given this.
     run_dialog_focusing_steps();
@@ -224,11 +236,23 @@ WebIDL::ExceptionOr<void> HTMLDialogElement::show_a_modal_dialog(HTMLDialogEleme
     subject.set_close_watcher();
 
     // FIXME: 18. Set subject's previously focused element to the focused element.
-    // FIXME: 19. Let document be subject's node document.
-    // FIXME: 20. Let hideUntil be the result of running topmost popover ancestor given subject, document's showing hint popover list, null, and false.
-    // FIXME: 21. If hideUntil is null, then set hideUntil to the result of running topmost popover ancestor given subject, document's showing auto popover list, null, and false.
-    // FIXME: 22. If hideUntil is null, then set hideUntil to document.
-    // FIXME: 23. Run hide all popovers until given hideUntil, false, and true.
+
+    // 19. Let document be subject's node document.
+    auto& document = subject.document();
+
+    // 20. Let hideUntil be the result of running topmost popover ancestor given subject, document's showing hint popover list, null, and false.
+    Variant<GC::Ptr<HTMLElement>, GC::Ptr<DOM::Document>> hide_until = topmost_popover_ancestor(subject, document.showing_hint_popover_list(), nullptr, IsPopover::No);
+
+    // 21. If hideUntil is null, then set hideUntil to the result of running topmost popover ancestor given subject, document's showing auto popover list, null, and false.
+    if (!hide_until.get<GC::Ptr<HTMLElement>>())
+        hide_until = topmost_popover_ancestor(subject, document.showing_auto_popover_list(), nullptr, IsPopover::No);
+
+    // 22. If hideUntil is null, then set hideUntil to document.
+    if (!hide_until.get<GC::Ptr<HTMLElement>>())
+        hide_until = GC::Ptr(document);
+
+    // 23. Run hide all popovers until given hideUntil, false, and true.
+    hide_all_popovers_until(hide_until, FocusPreviousElement::No, FireEvents::Yes);
 
     // 24. Run the dialog focusing steps given subject.
     subject.run_dialog_focusing_steps();