feat: Create datawriter class#22
Open
M1KUS3Q wants to merge 13 commits into
Open
Conversation
MichalSzandar
requested changes
Jun 8, 2026
MichalSzandar
requested changes
Jun 10, 2026
MichalSzandar
left a comment
MichalSzandar
left a comment
Collaborator
There was a problem hiding this comment.
- Create IDataFormatStrategy virtual class
- add unique_ptr< IDataFormatStrategy> in DataWriter
Comment on lines
+70
to
+81
| EEGData eegData; | ||
| while (eegQueue->try_dequeue(eegData)) { | ||
| writeEEGData(eegData); | ||
| } | ||
| } | ||
|
|
||
| if (markerQueue) { | ||
| Marker marker; | ||
| while (markerQueue->try_dequeue(marker)) { | ||
| writeMarker(marker); | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Don't repeat yourself
Comment on lines
+84
to
+97
| void DataWriter::writeEEGData(const EEGData& data) { | ||
| outputFile << "eeg," << data.timestamp << ",\""; | ||
| for (std::size_t index = 0; index < data.channels.size(); ++index) { | ||
| if (index > 0) { | ||
| outputFile << ','; | ||
| } | ||
| outputFile << data.channels[index]; | ||
| } | ||
| outputFile << '"' << '\n'; | ||
| } | ||
|
|
||
| void DataWriter::writeMarker(const Marker& marker) { | ||
| outputFile << "marker," << marker.timestamp << ",\"" << marker.eventName << '"' << '\n'; | ||
| } |
Collaborator
There was a problem hiding this comment.
Move those to CSVFormatStrategy
MichalSzandar
requested changes
Jun 11, 2026
| return wroteData; | ||
| } | ||
|
|
||
| DataWriter::DataWriter() : formatStrategy(std::make_unique<CSVFormatStrategy>()) {} |
Collaborator
There was a problem hiding this comment.
pass IDataFormatStrategy as argument for DataWriter constructor, delete default constructor.
Comment on lines
+19
to
+22
| virtual void writeHeader(std::ofstream& outputFile) const = 0; | ||
| virtual void writeEEGData(std::ofstream& outputFile, const EEGData& data) const = 0; | ||
| virtual void writeMarker(std::ofstream& outputFile, const Marker& marker) const = 0; | ||
| }; |
Collaborator
There was a problem hiding this comment.
The issue is that you force every strategy to use std::ofstream as a way to save data which is not good, because in other strategies like FifFormatStrategy we're (most likely) going to use Fiffstream to save our data. I think it would be better to add open(std::string filepath) function as I suggested in the UML diagram.
Comment on lines
+1
to
+20
| #ifndef EEGDATA_HPP | ||
| #define EEGDATA_HPP | ||
|
|
||
| #include <utility> | ||
| #include <vector> | ||
|
|
||
| struct EEGData { | ||
| std::vector<float> channels; | ||
| double timestamp = 0.0; | ||
|
|
||
| EEGData() = default; | ||
|
|
||
| EEGData(const std::vector<float>& channelValues, double sampleTimestamp) | ||
| : channels(channelValues), timestamp(sampleTimestamp) {} | ||
|
|
||
| EEGData(std::vector<float>&& channelValues, double sampleTimestamp) | ||
| : channels(std::move(channelValues)), timestamp(sampleTimestamp) {} | ||
| }; | ||
|
|
||
| #endif // EEGDATA_HPP No newline at end of file |
Collaborator
There was a problem hiding this comment.
I would consider moving EEGData and Marker classes to seperate directory like include/data_structures or something like that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create DataWriter class and Marker, EEGData struct stubs, along with 2 basic unit tests for the DataWriter.
resolves #7