Skip to content

[JEWEL-1302] Hide redundant VerticallyScrollableContainer/HorizontallyScrollableContainer API #3484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DanielSouzaBertoldi wants to merge 1 commit into from
+14 −6
Closed

[JEWEL-1302] Hide redundant VerticallyScrollableContainer/HorizontallyScrollableContainer API #3484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions platform/jewel/ui/api-dump.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,12 +632,12 @@
- sf:HorizontallyScrollableContainer(androidx.compose.foundation.gestures.ScrollableState,androidx.compose.ui.Modifier,androidx.compose.ui.Modifier,org.jetbrains.jewel.ui.component.styling.ScrollbarStyle,Z,Z,androidx.compose.foundation.interaction.MutableInteractionSource,kotlin.jvm.functions.Function3,androidx.compose.runtime.Composer,I,I):V
- bsf:HorizontallyScrollableContainer(androidx.compose.foundation.lazy.LazyListState,androidx.compose.ui.Modifier,androidx.compose.ui.Modifier,org.jetbrains.jewel.ui.component.styling.ScrollbarStyle,Z,Z,androidx.compose.foundation.interaction.MutableInteractionSource,kotlin.jvm.functions.Function3,androidx.compose.runtime.Composer,I,I):V
- bsf:HorizontallyScrollableContainer(androidx.compose.foundation.lazy.grid.LazyGridState,androidx.compose.ui.Modifier,androidx.compose.ui.Modifier,org.jetbrains.jewel.ui.component.styling.ScrollbarStyle,Z,Z,androidx.compose.foundation.interaction.MutableInteractionSource,kotlin.jvm.functions.Function3,androidx.compose.runtime.Composer,I,I):V
- sf:HorizontallyScrollableContainer(androidx.compose.ui.Modifier,androidx.compose.ui.Modifier,androidx.compose.foundation.ScrollState,org.jetbrains.jewel.ui.component.styling.ScrollbarStyle,Z,Z,androidx.compose.foundation.interaction.MutableInteractionSource,kotlin.jvm.functions.Function3,androidx.compose.runtime.Composer,I,I):V
- bsf:HorizontallyScrollableContainer(androidx.compose.ui.Modifier,androidx.compose.ui.Modifier,androidx.compose.foundation.ScrollState,org.jetbrains.jewel.ui.component.styling.ScrollbarStyle,Z,Z,androidx.compose.foundation.interaction.MutableInteractionSource,kotlin.jvm.functions.Function3,androidx.compose.runtime.Composer,I,I):V

Check failure on line 635 in platform/jewel/ui/api-dump.txt

View workflow job for this annotation

GitHub Actions / Annotate breaking API changes with IJP dumps

Breaking API change 

This looks like a breaking API change, make sure it's intended.
- sf:HorizontallyScrollableContainer(androidx.compose.ui.Modifier,androidx.compose.ui.Modifier,androidx.compose.foundation.ScrollState,org.jetbrains.jewel.ui.component.styling.ScrollbarStyle,Z,Z,Z,androidx.compose.foundation.interaction.MutableInteractionSource,kotlin.jvm.functions.Function3,androidx.compose.runtime.Composer,I,I):V
- sf:VerticallyScrollableContainer(androidx.compose.foundation.gestures.ScrollableState,androidx.compose.ui.Modifier,androidx.compose.ui.Modifier,org.jetbrains.jewel.ui.component.styling.ScrollbarStyle,Z,Z,androidx.compose.foundation.interaction.MutableInteractionSource,kotlin.jvm.functions.Function3,androidx.compose.runtime.Composer,I,I):V
- bsf:VerticallyScrollableContainer(androidx.compose.foundation.lazy.LazyListState,androidx.compose.ui.Modifier,androidx.compose.ui.Modifier,org.jetbrains.jewel.ui.component.styling.ScrollbarStyle,Z,Z,androidx.compose.foundation.interaction.MutableInteractionSource,kotlin.jvm.functions.Function3,androidx.compose.runtime.Composer,I,I):V
- bsf:VerticallyScrollableContainer(androidx.compose.foundation.lazy.grid.LazyGridState,androidx.compose.ui.Modifier,androidx.compose.ui.Modifier,org.jetbrains.jewel.ui.component.styling.ScrollbarStyle,Z,Z,androidx.compose.foundation.interaction.MutableInteractionSource,kotlin.jvm.functions.Function3,androidx.compose.runtime.Composer,I,I):V
- sf:VerticallyScrollableContainer(androidx.compose.ui.Modifier,androidx.compose.ui.Modifier,androidx.compose.foundation.ScrollState,org.jetbrains.jewel.ui.component.styling.ScrollbarStyle,Z,Z,androidx.compose.foundation.interaction.MutableInteractionSource,kotlin.jvm.functions.Function3,androidx.compose.runtime.Composer,I,I):V
- bsf:VerticallyScrollableContainer(androidx.compose.ui.Modifier,androidx.compose.ui.Modifier,androidx.compose.foundation.ScrollState,org.jetbrains.jewel.ui.component.styling.ScrollbarStyle,Z,Z,androidx.compose.foundation.interaction.MutableInteractionSource,kotlin.jvm.functions.Function3,androidx.compose.runtime.Composer,I,I):V

Check failure on line 640 in platform/jewel/ui/api-dump.txt

View workflow job for this annotation

GitHub Actions / Annotate breaking API changes with IJP dumps

Breaking API change 

This looks like a breaking API change, make sure it's intended.
- sf:VerticallyScrollableContainer(androidx.compose.ui.Modifier,androidx.compose.ui.Modifier,androidx.compose.foundation.ScrollState,org.jetbrains.jewel.ui.component.styling.ScrollbarStyle,Z,Z,Z,androidx.compose.foundation.interaction.MutableInteractionSource,kotlin.jvm.functions.Function3,androidx.compose.runtime.Composer,I,I):V
- sf:scrollbarContentSafePadding(org.jetbrains.jewel.ui.component.styling.ScrollbarStyle,androidx.compose.runtime.Composer,I,I):F
f:org.jetbrains.jewel.ui.component.ScrollbarKt
Expand Down
4 changes: 2 additions & 2 deletions platform/jewel/ui/metalava/ui-api-0.36.0.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,12 +683,12 @@ package org.jetbrains.jewel.ui.component {
method @androidx.compose.runtime.Composable public static void HorizontallyScrollableContainer(androidx.compose.foundation.gestures.ScrollableState scrollState, optional androidx.compose.ui.Modifier modifier, optional androidx.compose.ui.Modifier scrollbarModifier, optional org.jetbrains.jewel.ui.component.styling.ScrollbarStyle style, optional boolean reverseLayout, optional boolean scrollbarEnabled, optional androidx.compose.foundation.interaction.MutableInteractionSource scrollbarInteractionSource, kotlin.jvm.functions.Function1<? super androidx.compose.foundation.layout.BoxScope,kotlin.Unit> content);
method @Deprecated @androidx.compose.runtime.Composable public static void HorizontallyScrollableContainer(androidx.compose.foundation.lazy.grid.LazyGridState scrollState, optional androidx.compose.ui.Modifier modifier, optional androidx.compose.ui.Modifier scrollbarModifier, optional org.jetbrains.jewel.ui.component.styling.ScrollbarStyle style, optional boolean reverseLayout, optional boolean scrollbarEnabled, optional androidx.compose.foundation.interaction.MutableInteractionSource scrollbarInteractionSource, kotlin.jvm.functions.Function1<? super androidx.compose.foundation.layout.BoxScope,kotlin.Unit> content);
method @Deprecated @androidx.compose.runtime.Composable public static void HorizontallyScrollableContainer(androidx.compose.foundation.lazy.LazyListState scrollState, optional androidx.compose.ui.Modifier modifier, optional androidx.compose.ui.Modifier scrollbarModifier, optional org.jetbrains.jewel.ui.component.styling.ScrollbarStyle style, optional boolean reverseLayout, optional boolean scrollbarEnabled, optional androidx.compose.foundation.interaction.MutableInteractionSource scrollbarInteractionSource, kotlin.jvm.functions.Function1<? super androidx.compose.foundation.layout.BoxScope,kotlin.Unit> content);
method @androidx.compose.runtime.Composable public static void HorizontallyScrollableContainer(optional androidx.compose.ui.Modifier modifier, optional androidx.compose.ui.Modifier scrollbarModifier, optional androidx.compose.foundation.ScrollState scrollState, optional org.jetbrains.jewel.ui.component.styling.ScrollbarStyle style, optional boolean reverseLayout, optional boolean scrollbarEnabled, optional androidx.compose.foundation.interaction.MutableInteractionSource scrollbarInteractionSource, kotlin.jvm.functions.Function1<? super androidx.compose.foundation.layout.BoxScope,kotlin.Unit> content);
method @Deprecated @androidx.compose.runtime.Composable public static void HorizontallyScrollableContainer(optional androidx.compose.ui.Modifier modifier, optional androidx.compose.ui.Modifier scrollbarModifier, optional androidx.compose.foundation.ScrollState scrollState, optional org.jetbrains.jewel.ui.component.styling.ScrollbarStyle style, optional boolean reverseLayout, optional boolean scrollbarEnabled, optional androidx.compose.foundation.interaction.MutableInteractionSource scrollbarInteractionSource, kotlin.jvm.functions.Function1<? super androidx.compose.foundation.layout.BoxScope,kotlin.Unit> content);
method @androidx.compose.runtime.Composable public static void HorizontallyScrollableContainer(optional androidx.compose.ui.Modifier modifier, optional androidx.compose.ui.Modifier scrollbarModifier, optional androidx.compose.foundation.ScrollState scrollState, optional org.jetbrains.jewel.ui.component.styling.ScrollbarStyle style, optional boolean reverseLayout, optional boolean userScrollEnabled, optional boolean scrollbarEnabled, optional androidx.compose.foundation.interaction.MutableInteractionSource scrollbarInteractionSource, kotlin.jvm.functions.Function1<? super androidx.compose.foundation.layout.BoxScope,kotlin.Unit> content);
method @androidx.compose.runtime.Composable public static void VerticallyScrollableContainer(androidx.compose.foundation.gestures.ScrollableState scrollState, optional androidx.compose.ui.Modifier modifier, optional androidx.compose.ui.Modifier scrollbarModifier, optional org.jetbrains.jewel.ui.component.styling.ScrollbarStyle style, optional boolean reverseLayout, optional boolean scrollbarEnabled, optional androidx.compose.foundation.interaction.MutableInteractionSource scrollbarInteractionSource, kotlin.jvm.functions.Function1<? super androidx.compose.foundation.layout.BoxScope,kotlin.Unit> content);
method @Deprecated @androidx.compose.runtime.Composable public static void VerticallyScrollableContainer(androidx.compose.foundation.lazy.grid.LazyGridState scrollState, optional androidx.compose.ui.Modifier modifier, optional androidx.compose.ui.Modifier scrollbarModifier, optional org.jetbrains.jewel.ui.component.styling.ScrollbarStyle style, optional boolean reverseLayout, optional boolean scrollbarEnabled, optional androidx.compose.foundation.interaction.MutableInteractionSource scrollbarInteractionSource, kotlin.jvm.functions.Function1<? super androidx.compose.foundation.layout.BoxScope,kotlin.Unit> content);
method @Deprecated @androidx.compose.runtime.Composable public static void VerticallyScrollableContainer(androidx.compose.foundation.lazy.LazyListState scrollState, optional androidx.compose.ui.Modifier modifier, optional androidx.compose.ui.Modifier scrollbarModifier, optional org.jetbrains.jewel.ui.component.styling.ScrollbarStyle style, optional boolean reverseLayout, optional boolean scrollbarEnabled, optional androidx.compose.foundation.interaction.MutableInteractionSource scrollbarInteractionSource, kotlin.jvm.functions.Function1<? super androidx.compose.foundation.layout.BoxScope,kotlin.Unit> content);
method @androidx.compose.runtime.Composable public static void VerticallyScrollableContainer(optional androidx.compose.ui.Modifier modifier, optional androidx.compose.ui.Modifier scrollbarModifier, optional androidx.compose.foundation.ScrollState scrollState, optional org.jetbrains.jewel.ui.component.styling.ScrollbarStyle style, optional boolean reverseLayout, optional boolean scrollbarEnabled, optional androidx.compose.foundation.interaction.MutableInteractionSource scrollbarInteractionSource, kotlin.jvm.functions.Function1<? super androidx.compose.foundation.layout.BoxScope,kotlin.Unit> content);
method @Deprecated @androidx.compose.runtime.Composable public static void VerticallyScrollableContainer(optional androidx.compose.ui.Modifier modifier, optional androidx.compose.ui.Modifier scrollbarModifier, optional androidx.compose.foundation.ScrollState scrollState, optional org.jetbrains.jewel.ui.component.styling.ScrollbarStyle style, optional boolean reverseLayout, optional boolean scrollbarEnabled, optional androidx.compose.foundation.interaction.MutableInteractionSource scrollbarInteractionSource, kotlin.jvm.functions.Function1<? super androidx.compose.foundation.layout.BoxScope,kotlin.Unit> content);
method @androidx.compose.runtime.Composable public static void VerticallyScrollableContainer(optional androidx.compose.ui.Modifier modifier, optional androidx.compose.ui.Modifier scrollbarModifier, optional androidx.compose.foundation.ScrollState scrollState, optional org.jetbrains.jewel.ui.component.styling.ScrollbarStyle style, optional boolean reverseLayout, optional boolean userScrollEnabled, optional boolean scrollbarEnabled, optional androidx.compose.foundation.interaction.MutableInteractionSource scrollbarInteractionSource, kotlin.jvm.functions.Function1<? super androidx.compose.foundation.layout.BoxScope,kotlin.Unit> content);
method @androidx.compose.runtime.Composable public static float scrollbarContentSafePadding(optional org.jetbrains.jewel.ui.component.styling.ScrollbarStyle style);
}
Expand Down
4 changes: 2 additions & 2 deletions platform/jewel/ui/metalava/ui-api-stable-0.36.0.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,12 +641,12 @@ package org.jetbrains.jewel.ui.component {
method @androidx.compose.runtime.Composable public static void HorizontallyScrollableContainer(androidx.compose.foundation.gestures.ScrollableState scrollState, optional androidx.compose.ui.Modifier modifier, optional androidx.compose.ui.Modifier scrollbarModifier, optional org.jetbrains.jewel.ui.component.styling.ScrollbarStyle style, optional boolean reverseLayout, optional boolean scrollbarEnabled, optional androidx.compose.foundation.interaction.MutableInteractionSource scrollbarInteractionSource, kotlin.jvm.functions.Function1<? super androidx.compose.foundation.layout.BoxScope,kotlin.Unit> content);
method @Deprecated @androidx.compose.runtime.Composable public static void HorizontallyScrollableContainer(androidx.compose.foundation.lazy.grid.LazyGridState scrollState, optional androidx.compose.ui.Modifier modifier, optional androidx.compose.ui.Modifier scrollbarModifier, optional org.jetbrains.jewel.ui.component.styling.ScrollbarStyle style, optional boolean reverseLayout, optional boolean scrollbarEnabled, optional androidx.compose.foundation.interaction.MutableInteractionSource scrollbarInteractionSource, kotlin.jvm.functions.Function1<? super androidx.compose.foundation.layout.BoxScope,kotlin.Unit> content);
method @Deprecated @androidx.compose.runtime.Composable public static void HorizontallyScrollableContainer(androidx.compose.foundation.lazy.LazyListState scrollState, optional androidx.compose.ui.Modifier modifier, optional androidx.compose.ui.Modifier scrollbarModifier, optional org.jetbrains.jewel.ui.component.styling.ScrollbarStyle style, optional boolean reverseLayout, optional boolean scrollbarEnabled, optional androidx.compose.foundation.interaction.MutableInteractionSource scrollbarInteractionSource, kotlin.jvm.functions.Function1<? super androidx.compose.foundation.layout.BoxScope,kotlin.Unit> content);
method @androidx.compose.runtime.Composable public static void HorizontallyScrollableContainer(optional androidx.compose.ui.Modifier modifier, optional androidx.compose.ui.Modifier scrollbarModifier, optional androidx.compose.foundation.ScrollState scrollState, optional org.jetbrains.jewel.ui.component.styling.ScrollbarStyle style, optional boolean reverseLayout, optional boolean scrollbarEnabled, optional androidx.compose.foundation.interaction.MutableInteractionSource scrollbarInteractionSource, kotlin.jvm.functions.Function1<? super androidx.compose.foundation.layout.BoxScope,kotlin.Unit> content);
method @Deprecated @androidx.compose.runtime.Composable public static void HorizontallyScrollableContainer(optional androidx.compose.ui.Modifier modifier, optional androidx.compose.ui.Modifier scrollbarModifier, optional androidx.compose.foundation.ScrollState scrollState, optional org.jetbrains.jewel.ui.component.styling.ScrollbarStyle style, optional boolean reverseLayout, optional boolean scrollbarEnabled, optional androidx.compose.foundation.interaction.MutableInteractionSource scrollbarInteractionSource, kotlin.jvm.functions.Function1<? super androidx.compose.foundation.layout.BoxScope,kotlin.Unit> content);
method @androidx.compose.runtime.Composable public static void HorizontallyScrollableContainer(optional androidx.compose.ui.Modifier modifier, optional androidx.compose.ui.Modifier scrollbarModifier, optional androidx.compose.foundation.ScrollState scrollState, optional org.jetbrains.jewel.ui.component.styling.ScrollbarStyle style, optional boolean reverseLayout, optional boolean userScrollEnabled, optional boolean scrollbarEnabled, optional androidx.compose.foundation.interaction.MutableInteractionSource scrollbarInteractionSource, kotlin.jvm.functions.Function1<? super androidx.compose.foundation.layout.BoxScope,kotlin.Unit> content);
method @androidx.compose.runtime.Composable public static void VerticallyScrollableContainer(androidx.compose.foundation.gestures.ScrollableState scrollState, optional androidx.compose.ui.Modifier modifier, optional androidx.compose.ui.Modifier scrollbarModifier, optional org.jetbrains.jewel.ui.component.styling.ScrollbarStyle style, optional boolean reverseLayout, optional boolean scrollbarEnabled, optional androidx.compose.foundation.interaction.MutableInteractionSource scrollbarInteractionSource, kotlin.jvm.functions.Function1<? super androidx.compose.foundation.layout.BoxScope,kotlin.Unit> content);
method @Deprecated @androidx.compose.runtime.Composable public static void VerticallyScrollableContainer(androidx.compose.foundation.lazy.grid.LazyGridState scrollState, optional androidx.compose.ui.Modifier modifier, optional androidx.compose.ui.Modifier scrollbarModifier, optional org.jetbrains.jewel.ui.component.styling.ScrollbarStyle style, optional boolean reverseLayout, optional boolean scrollbarEnabled, optional androidx.compose.foundation.interaction.MutableInteractionSource scrollbarInteractionSource, kotlin.jvm.functions.Function1<? super androidx.compose.foundation.layout.BoxScope,kotlin.Unit> content);
method @Deprecated @androidx.compose.runtime.Composable public static void VerticallyScrollableContainer(androidx.compose.foundation.lazy.LazyListState scrollState, optional androidx.compose.ui.Modifier modifier, optional androidx.compose.ui.Modifier scrollbarModifier, optional org.jetbrains.jewel.ui.component.styling.ScrollbarStyle style, optional boolean reverseLayout, optional boolean scrollbarEnabled, optional androidx.compose.foundation.interaction.MutableInteractionSource scrollbarInteractionSource, kotlin.jvm.functions.Function1<? super androidx.compose.foundation.layout.BoxScope,kotlin.Unit> content);
method @androidx.compose.runtime.Composable public static void VerticallyScrollableContainer(optional androidx.compose.ui.Modifier modifier, optional androidx.compose.ui.Modifier scrollbarModifier, optional androidx.compose.foundation.ScrollState scrollState, optional org.jetbrains.jewel.ui.component.styling.ScrollbarStyle style, optional boolean reverseLayout, optional boolean scrollbarEnabled, optional androidx.compose.foundation.interaction.MutableInteractionSource scrollbarInteractionSource, kotlin.jvm.functions.Function1<? super androidx.compose.foundation.layout.BoxScope,kotlin.Unit> content);
method @Deprecated @androidx.compose.runtime.Composable public static void VerticallyScrollableContainer(optional androidx.compose.ui.Modifier modifier, optional androidx.compose.ui.Modifier scrollbarModifier, optional androidx.compose.foundation.ScrollState scrollState, optional org.jetbrains.jewel.ui.component.styling.ScrollbarStyle style, optional boolean reverseLayout, optional boolean scrollbarEnabled, optional androidx.compose.foundation.interaction.MutableInteractionSource scrollbarInteractionSource, kotlin.jvm.functions.Function1<? super androidx.compose.foundation.layout.BoxScope,kotlin.Unit> content);
method @androidx.compose.runtime.Composable public static void VerticallyScrollableContainer(optional androidx.compose.ui.Modifier modifier, optional androidx.compose.ui.Modifier scrollbarModifier, optional androidx.compose.foundation.ScrollState scrollState, optional org.jetbrains.jewel.ui.component.styling.ScrollbarStyle style, optional boolean reverseLayout, optional boolean userScrollEnabled, optional boolean scrollbarEnabled, optional androidx.compose.foundation.interaction.MutableInteractionSource scrollbarInteractionSource, kotlin.jvm.functions.Function1<? super androidx.compose.foundation.layout.BoxScope,kotlin.Unit> content);
method @androidx.compose.runtime.Composable public static float scrollbarContentSafePadding(optional org.jetbrains.jewel.ui.component.styling.ScrollbarStyle style);
}
Expand Down
Loading
Loading