[JEWEL-1302] Hide redundant VerticallyScrollableContainer/HorizontallyScrollableContainer API

[DanielSouzaBertoldi]

This API is redundant because the second overload with userScrollEnabled: Boolean = true as a default:

public fun VerticallyScrollableContainer(
    modifier: Modifier = Modifier,
    scrollbarModifier: Modifier = Modifier,
    scrollState: ScrollState = rememberScrollState(),
    style: ScrollbarStyle = JewelTheme.scrollbarStyle,
    reverseLayout: Boolean = false,
    userScrollEnabled: Boolean = true,
    scrollbarEnabled: Boolean = userScrollEnabled,
    scrollbarInteractionSource: MutableInteractionSource = remember { MutableInteractionSource() },
    content: @Composable BoxScope.() -> Unit,
)

Makes this overload a strict subset of it. Every possible call to the first overload is replicated identically by calling the second overload and simply omitting userScrollEnabled (which defaults to true).

The same is true for HorizontallyScrollableContainer

[DanielSouzaBertoldi]

Pretty sure there's not much I can do to stop this error from failing the CI code checks job 😬

[rock3r]

@DanielSouzaBertoldi https://plugins.gradle.org/plugin/com.gradle.develocity maybe try upgrading to the latest 4.4.0?

[DanielSouzaBertoldi]

Yeah JetBrains Space is down... https://status.jetbrains.space/

Even trying to delete mentions to develocity/foojay I still got 503:

I'm investigating it more, but it seems like the CI environment is bugged 🤔

Unless.... JetBrains Space got discontinued?

[rock3r]

I think it was supposed to eventually be, but I assume someone would have told us? Perhaps? XD

[DanielSouzaBertoldi]

Yeah that would've been nice 😭

Couldn't find anything though related to the discontinuation of this particular link. However, the CMP compatibility page now points to this URL for dev builds:

maven("https://redirector.kotlinlang.org/maven/compose-dev")

I just pushed the changes to all of our modules, just to see if the CI is finally going to be happy about it. Locally the old link was working, but I guess that's because it was cached locally. I don't like to mess with Gradle caches anyways so I'll leave it to the CI to give us a sign 🙏🏻

[DanielSouzaBertoldi]

Nice, that did it :) I'll update the maven links for real on JEWEL-1301 though. Then I can also update the documentation

(besides, that PR won't break the metalava job.... probably. Making it easier to merge quickly)

[rock3r]

@DanielSouzaBertoldi can you resolve conflicts?

[DanielSouzaBertoldi]

As we discussed yesterday, the annotate breaking changes job should not be treated as blocking, so we can ignore it

Previous comment

I can't make sense of what's being asked.

It claims the API was removed, while it was actually just hidden:

The API dump is correct, so I'm not sure what's wrong here. "IJP Dumps" to me seems like it's mentioning ApiCheckTest, which is passing 🤔

---

I think that maybe the script (annotate-api-dump-changes.main.kts) itself should check for modificarions? It currently just only checks if a line in the diff has -:

line.startsWith("-") && !line.startsWith("---") -> {
    reportBreakage(
        file,
        line,
        log,
        oldLineNum,
        newLineNum,
        experimental,
        annotate = !lastLineWasRemoval,
        jewelRoot,
    )
    foundBreakages = true
    oldLineNum++
    lastLineWasRemoval = true
}

Without checking if it is immediately followed by a +, so a modification, not a deletion 🤔

[rock3r]

@DanielSouzaBertoldi is the red check intended? Is this ready to go now?