Skip to content

fix: Add loading state only on the correct button on the login screen #2910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Elouan1411 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: Add loading state only on the correct button on the login screen #2910

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions app/src/main/java/com/infomaniak/mail/ui/login/LoginFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ class LoginFragment : Fragment() {
}

private suspend fun connectSelectedAccounts(accounts: List<ExternalAccount>, skippedIds: Set<Long>) {
startLoadingLoginButtons()
startLoadingLoginButton()
val accountsToLogin = accounts.filterSelectedAccounts(skippedIds)
val loginResult = crossAppLoginViewModel.attemptLogin(selectedAccounts = accountsToLogin)
loginUsers(loginResult)
Expand Down Expand Up @@ -199,7 +199,7 @@ class LoginFragment : Fragment() {

@VisibleForTesting
fun openLoginWebView() {
startLoadingLoginButtons()
startLoadingLoginButton()
trackAccountEvent(MatomoName.OpenLoginWebview)
loginActivity.infomaniakLogin.startWebViewLogin(webViewLoginResultLauncher)
}
Expand All @@ -213,9 +213,8 @@ class LoginFragment : Fragment() {
resetLoginButtons()
}

private fun startLoadingLoginButtons() {
private fun startLoadingLoginButton() {
isLoginButtonLoading = true
isSignUpButtonLoading = true
}

private fun resetLoginButtons() {
Expand Down
Loading