fix: Add loading state only on the correct button on the login screen#2910
Draft
Elouan1411 wants to merge 1 commit into
Draft
fix: Add loading state only on the correct button on the login screen#2910Elouan1411 wants to merge 1 commit into
Elouan1411 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the login screen’s loading-state handling so only the button initiating the action shows a loading indicator.
Changes:
- Replace the shared
startLoadingLoginButtons()call with a login-specificstartLoadingLoginButton(). - Add a separate
startLoadingSignUpButton()and trigger it when navigating to account creation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
207
to
210
| private fun openAccountCreation() { | ||
| startLoadingSignUpButton() | ||
| safelyNavigate(LoginFragmentDirections.actionLoginFragmentToNewAccountFragment()) | ||
| } |
Elouan1411
force-pushed
the
remove-double-loader-login-screen
branch
from
89e7b17 to
2e6d852
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.