Skip to content

libidn 2.0.2#12959

Closed
DomT4 wants to merge 5 commits into
Homebrew:masterfrom
DomT4:libidn
Closed

libidn 2.0.2#12959
DomT4 wants to merge 5 commits into
Homebrew:masterfrom
DomT4:libidn

Conversation

@DomT4
Copy link
Copy Markdown
Contributor

@DomT4 DomT4 commented Apr 27, 2017

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

An alternative implementation of #12885. Opening here so @ilovezfs & @MikeMcQuaid can keep track of how things are going. Feel free to tag with the Do Not Merge tag for now.

@stale stale Bot added the stale No recent activity label May 18, 2017
@stale
Copy link
Copy Markdown

stale Bot commented May 18, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@DomT4
Copy link
Copy Markdown
Contributor Author

DomT4 commented May 19, 2017

Haven't forgotten this. Think upstream accidentally oversold how drop-in compatible these two versions of libidn would actually be in practice, but I will sink some more time into this soonish.

@stale stale Bot removed the stale No recent activity label May 19, 2017
@ilovezfs
Copy link
Copy Markdown
Contributor

Which formulae only work with v2?

@DomT4
Copy link
Copy Markdown
Contributor Author

DomT4 commented May 19, 2017 via email

@ilovezfs
Copy link
Copy Markdown
Contributor

So far it's looking like they jumped the gun.

@MikeMcQuaid
Copy link
Copy Markdown
Member

Yeh, libidn@2 smells like a better option at this point.

@ilovezfs
Copy link
Copy Markdown
Contributor

I'm not even sure we should do that.

@MikeMcQuaid
Copy link
Copy Markdown
Member

@ilovezfs 👍 I mean if we did add the option back

@DomT4 DomT4 closed this Jun 2, 2017
@DomT4 DomT4 deleted the libidn branch June 2, 2017 16:50
@ilovezfs ilovezfs mentioned this pull request Aug 22, 2017
4 tasks
@DomT4 DomT4 mentioned this pull request Dec 11, 2017
4 tasks
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants