Skip to content

Add blackdetect params #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davisdude wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add blackdetect params #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54be303
Added blackdetect params
davisdude Jul 10, 2023
e9b8f77
Added back quiet
davisdude Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions deblack/deblack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,13 @@ def construct_ffmpeg_trim_cmd(timepairs, inpath, outpath, has_audio=True):
return cmd


def get_blackdetect(inpath, invert=False):
def get_blackdetect(inpath, duration, pic_threshold, pix_threshold, invert=False):
ffprobe_cmd = [
"ffprobe",
"-f",
"lavfi",
"-i",
f"movie={inpath},blackdetect[out0]",
f"movie={inpath},blackdetect=black_min_duration={duration}:picture_black_ratio_th={pic_threshold}:pixel_black_th={pix_threshold}[out0]",
"-show_entries",
"tags=lavfi.black_start,lavfi.black_end",
"-of",
Expand Down Expand Up @@ -94,6 +94,9 @@ def str2bool(v):
parser.add_argument("input", type=str, help="input video file")
parser.add_argument("--invert", action="store_true", help="remove nonblack instead of removing black")
parser.add_argument("--audio", type=str2bool, default="auto", help="input video contains audio? (auto, yes, no)")
parser.add_argument("--black-min-duration", type=float, default=2.0, help="Minimum length of time to consider - see https://ffmpeg.org/ffmpeg-filters.html#blackdetect for more")
Copy link
Copy Markdown
Contributor Author

@davisdude davisdude Jul 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If, instead of hard-coding the defaults, you'd prefer to have more complicated logic around passing the values to the function itself, I can do that.

parser.add_argument("--picture-black-th", type=float, default=0.98, help="Picture blackness threshold - see https://ffmpeg.org/ffmpeg-filters.html#blackdetect for more")
parser.add_argument("--pixel-black-th", type=float, default=0.1, help="Pixel blackness threshold - see https://ffmpeg.org/ffmpeg-filters.html#blackdetect for more")
args = parser.parse_args()

##FIXME: sadly you must chdir so that the ffprobe command will work
Expand All @@ -113,7 +116,7 @@ def str2bool(v):
else:
args.audio = args.audio

timepairs = get_blackdetect(args.input, invert=args.invert)
timepairs = get_blackdetect(args.input, duration=args.black_min_duration, pic_threshold=args.picture_black_th, pix_threshold=args.pixel_black_th, invert=args.invert)
cmd = construct_ffmpeg_trim_cmd(timepairs, args.input, outpath, has_audio=args.audio)

print(cmd)
Expand Down