Add blackdetect params#4
Open
davisdude wants to merge 2 commits intoFarisHijazi:masterfrom
Open
Conversation
davisdude
commented
Jul 10, 2023
| parser.add_argument("input", type=str, help="input video file") | ||
| parser.add_argument("--invert", action="store_true", help="remove nonblack instead of removing black") | ||
| parser.add_argument("--audio", type=str2bool, default="auto", help="input video contains audio? (auto, yes, no)") | ||
| parser.add_argument("--black-min-duration", type=float, default=2.0, help="Minimum length of time to consider - see https://ffmpeg.org/ffmpeg-filters.html#blackdetect for more") |
Contributor
Author
There was a problem hiding this comment.
If, instead of hard-coding the defaults, you'd prefer to have more complicated logic around passing the values to the function itself, I can do that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This exposes the blackdetect filter's parameters so that you can use them instead of just the defaults.
The names are pretty arbitrary, so feel free to let me know if you'd like them changed to something else.