Skip to content

Make install-tool tool and tool version configurable #2649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
swang392 wants to merge 3 commits into
base: main
Choose a base branch
from
+7 −2
Open

Make install-tool tool and tool version configurable #2649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
313b9f0
add configurable tool and tool_version to install-info
swang392 May 11, 2026
59a056e
update values
swang392 May 11, 2026
c1255fa
undo
swang392 May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/datadog/templates/install_info-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ data:
install_info: |
---
install_method:
tool: helm
tool_version: {{ .Release.Service }}
tool: {{ .Values.datadog.installInfo.tool | default "helm" }}
tool_version: {{ .Values.datadog.installInfo.toolVersion | default .Release.Service }}
Comment on lines +14 to +15

@chatgpt-codex-connector chatgpt-codex-connector Bot May 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Quote installInfo values in rendered install_info YAML

The new datadog.installInfo.tool and toolVersion values are now user-controlled, but they are injected as unquoted scalars into the embedded install_info YAML. If either value contains YAML-significant content (for example ": ", #, or a newline), the resulting install_info payload can be parsed incorrectly or become invalid when the Agent reads it, which defeats the purpose of making these fields configurable. Rendering these fields with quoting (or JSON string escaping) avoids this regression while preserving arbitrary string input.

Useful? React with 👍 / 👎.

installer_version: {{ .Chart.Name }}-{{ .Chart.Version }}
3 changes: 3 additions & 0 deletions charts/datadog/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
"datadog": {
"type": "object",
"properties": {
"installInfo": {
"type": "object"
},
"apm": {
"type": "object",
"properties": {
Expand Down
2 changes: 2 additions & 0 deletions charts/datadog/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ datadog:
## If set, this parameter takes precedence over "appKey".
appKeyExistingSecret: # <DATADOG_APP_KEY_SECRET>

installInfo: {}

# agents.secretAnnotations -- Annotations to add to the Secrets
secretAnnotations: {}
# key: "value"
Expand Down
Loading