Skip to content

Make install-tool tool and tool version configurable#2649

Open
swang392 wants to merge 3 commits into
mainfrom
swang392/install-info-tool
Open

Make install-tool tool and tool version configurable#2649
swang392 wants to merge 3 commits into
mainfrom
swang392/install-info-tool

Conversation

@swang392

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • All commits are signed and show as "Verified" on GitHub (see: signing commits)
  • Chart Version semver bump label has been added (use <chartName>/minor-version, <chartName>/patch-version, or <chartName>/no-version-bump)
  • For datadog or datadog-operator chart or value changes, update the test baselines (run: make update-test-baselines)
  • For datadog chart changes, received ✅ from a member of your team

GitHub CI takes care of the below, but are still required:

  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md

@swang392 swang392 requested review from a team as code owners May 11, 2026 19:38
@swang392 swang392 requested review from tedkahwaji and removed request for a team May 11, 2026 19:38
@github-actions github-actions Bot added the chart/datadog This issue or pull request is related to the datadog chart label May 11, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c1255faf29

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +14 to +15
tool: {{ .Values.datadog.installInfo.tool | default "helm" }}
tool_version: {{ .Values.datadog.installInfo.toolVersion | default .Release.Service }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Quote installInfo values in rendered install_info YAML

The new datadog.installInfo.tool and toolVersion values are now user-controlled, but they are injected as unquoted scalars into the embedded install_info YAML. If either value contains YAML-significant content (for example ": ", #, or a newline), the resulting install_info payload can be parsed incorrectly or become invalid when the Agent reads it, which defeats the purpose of making these fields configurable. Rendering these fields with quoting (or JSON string escaping) avoids this regression while preserving arbitrary string input.

Useful? React with 👍 / 👎.

@fanny-jiang fanny-jiang added the on hold the PR is blocked on another contribution or action label May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chart/datadog This issue or pull request is related to the datadog chart on hold the PR is blocked on another contribution or action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants