Make install-tool tool and tool version configurable#2649
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c1255faf29
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tool: {{ .Values.datadog.installInfo.tool | default "helm" }} | ||
| tool_version: {{ .Values.datadog.installInfo.toolVersion | default .Release.Service }} |
There was a problem hiding this comment.
Quote installInfo values in rendered install_info YAML
The new datadog.installInfo.tool and toolVersion values are now user-controlled, but they are injected as unquoted scalars into the embedded install_info YAML. If either value contains YAML-significant content (for example ": ", #, or a newline), the resulting install_info payload can be parsed incorrectly or become invalid when the Agent reads it, which defeats the purpose of making these fields configurable. Rendering these fields with quoting (or JSON string escaping) avoids this regression while preserving arbitrary string input.
Useful? React with 👍 / 👎.
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
<chartName>/minor-version,<chartName>/patch-version, or<chartName>/no-version-bump)datadogordatadog-operatorchart or value changes, update the test baselines (run:make update-test-baselines)datadogchart changes, received ✅ from a member of your teamGitHub CI takes care of the below, but are still required:
.github/helm-docs.sh)CHANGELOG.mdhas been updatedREADME.md