Skip to content

Amcr 132 last of the welsh#442

Open
jason-ee wants to merge 24 commits intomainfrom
AMCR-132-last-of-the-Welsh
Open

Amcr 132 last of the welsh#442
jason-ee wants to merge 24 commits intomainfrom
AMCR-132-last-of-the-Welsh

Conversation

@jason-ee
Copy link
Copy Markdown
Contributor

@jason-ee jason-ee commented Apr 13, 2026

What

Adding Welsh translations missing from the regulator service when we inherited it.

Why

Accessibility and statutory obligation to have English translated into Welsh on government services.

Ticket url

Screenshots

Before After
todo todo

Pre-merge checklist

@jason-ee jason-ee requested a review from a team as a code owner April 13, 2026 11:41
NickBuckland
NickBuckland previously approved these changes Apr 13, 2026
Copy link
Copy Markdown
Contributor

@NickBuckland NickBuckland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna have to trust you :) The appear to be the correct resx items other than that 🤷‍♂️

@jason-ee jason-ee force-pushed the AMCR-132-last-of-the-Welsh branch from 16323cc to 55492f1 Compare April 15, 2026 09:19
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.

As per obligation checker repo.
Also tidy up a bit and remove sections not interesting to end users.
@timabell timabell force-pushed the AMCR-132-last-of-the-Welsh branch from 7f3539c to 7694aa4 Compare April 16, 2026 09:17
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.

@timabell
Copy link
Copy Markdown
Contributor

force push to kick off a fresh build. getting persistent unreleated failures on the owasp step

timabell
timabell previously approved these changes Apr 16, 2026
NickBuckland
NickBuckland previously approved these changes Apr 16, 2026
This phrase is used in the service with a different translation. Changed from Mynd i'r tudalen hafan to Ewch i'r cartref for consistency.
@jason-ee jason-ee dismissed stale reviews from NickBuckland and timabell via 9030741 May 1, 2026 14:10
jason-ee added 2 commits May 1, 2026 15:13
Phrase exists in system with different translation. Changing this one to match the existing version.
Phrase is translated differently in two places. Amending this to match the other.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants