Skip to content

Trigger transmission helper from KHR_materials_diffuse_transmission. #18451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MiiBond wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Trigger transmission helper from KHR_materials_diffuse_transmission. #18451

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a797a0
Trigger transmission helper from KHR_materials_diffuse_transmission.
MiiBond May 12, 2026
ea5244c
Add missing new file
MiiBond May 12, 2026
bd94a7f
Mark transmissionHelper as internal
MiiBond May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/dev/loaders/src/glTF/2.0/Extensions/KHR_materials_diffuse_transmission.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { GLTFLoader } from "../glTFLoader";
import { type IKHRMaterialsDiffuseTransmission } from "babylonjs-gltf2interface";
import { Color3 } from "core/Maths/math.color";
import { registerGLTFExtension, unregisterGLTFExtension } from "../glTFLoaderExtensionRegistry";
import { TransmissionHelper, type ITransmissionHelperHolder } from "./transmissionHelper";

const NAME = "KHR_materials_diffuse_transmission";

Expand Down Expand Up @@ -80,6 +81,17 @@ export class KHR_materials_diffuse_transmission implements IGLTFLoaderExtension
adapter.configureSubsurface();
adapter.subsurfaceWeight = extension.diffuseTransmissionFactor ?? 0;

// Handle transmission helper setup (only needed for PBR materials)
if (adapter.subsurfaceWeight > 0 && !this._loader.parent.dontUseTransmissionHelper) {
const scene = babylonMaterial.getScene() as unknown as ITransmissionHelperHolder;
if (!scene._transmissionHelper) {
new TransmissionHelper({}, babylonMaterial.getScene(), this._loader);
} else if (!scene._transmissionHelper?._isRenderTargetValid()) {
// If the render target is not valid, recreate it.
scene._transmissionHelper?._setupRenderTargets();
}
}

adapter.diffuseTransmissionTint = extension.diffuseTransmissionColorFactor !== undefined ? Color3.FromArray(extension.diffuseTransmissionColorFactor) : Color3.White();

const promises = new Array<Promise<any>>();
Expand Down
Loading
Loading