Skip to content

Trigger transmission helper from KHR_materials_diffuse_transmission.#18451

Open
MiiBond wants to merge 3 commits into
BabylonJS:masterfrom
MiiBond:mbond/transmission-helper-for-diffuse-transmission
Open

Trigger transmission helper from KHR_materials_diffuse_transmission.#18451
MiiBond wants to merge 3 commits into
BabylonJS:masterfrom
MiiBond:mbond/transmission-helper-for-diffuse-transmission

Conversation

@MiiBond
Copy link
Copy Markdown
Contributor

@MiiBond MiiBond commented May 12, 2026

This PR separates out the transmissionHelper from the KHR_materials_transmission and instantiates it from KHR_materials_diffuse_transmission as well.

@Popov72
Copy link
Copy Markdown
Contributor

Popov72 commented May 13, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@bjsplat
Copy link
Copy Markdown
Collaborator

bjsplat commented May 13, 2026

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Copy Markdown
Collaborator

bjsplat commented May 13, 2026

Snapshot stored with reference name:
refs/pull/18451/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/18451/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/18451/merge/index.html#WGZLGJ#4600

Links to test your changes to core in the published versions of the Babylon tools (does not contain changes you made to the tools themselves):

https://playground.babylonjs.com/?snapshot=refs/pull/18451/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/18451/merge
https://gui.babylonjs.com/?snapshot=refs/pull/18451/merge
https://nme.babylonjs.com/?snapshot=refs/pull/18451/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/18451/merge#BCU1XR#0

If you made changes to the sandbox or playground in this PR, additional comments will be generated soon containing links to the dev versions of those tools.

@bjsplat
Copy link
Copy Markdown
Collaborator

bjsplat commented May 13, 2026

@bjsplat
Copy link
Copy Markdown
Collaborator

bjsplat commented May 13, 2026

@bjsplat
Copy link
Copy Markdown
Collaborator

bjsplat commented May 13, 2026

⚡ Performance Test Results

🟢 All performance tests passed — no regressions detected.

@bjsplat
Copy link
Copy Markdown
Collaborator

bjsplat commented May 13, 2026

🟢 Memory Leak Test Results

13 passed, 0 leaked out of 13 scenarios

🟢 All memory leak tests passed — no leaks detected.

Passed Scenarios (13)
Scenario Package
Core Feature Stack @babylonjs/core
Core Rendering Materials Shadows Stack @babylonjs/core
Core Textures Render Targets PostProcess Stack @babylonjs/core
GUI Fullscreen UI Controls @babylonjs/gui
GUI Mesh ADT Controls @babylonjs/gui
Loaders Boombox Import @babylonjs/loaders
Loaders OBJ Direct Load @babylonjs/loaders
Loaders STL Direct Load @babylonjs/loaders
Materials Library Stack @babylonjs/materials
Serializers glTF Export @babylonjs/serializers
Serializers GLB Export @babylonjs/serializers
PostProcesses Digital Rain Stack @babylonjs/post-processes
Procedural Textures Stack @babylonjs/procedural-textures

@bjsplat
Copy link
Copy Markdown
Collaborator

bjsplat commented May 13, 2026

Comment thread packages/dev/loaders/src/glTF/2.0/Extensions/transmissionHelper.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants