Update auth lib to latest by isra-fel · Pull Request #29505 · Azure/azure-powershell

isra-fel · 2026-05-05T16:40:52Z

Update dependencies and suppress warnings for obsolete credential types
todo
Update package references and clean up unused dependencies across multiple projects
continue addressing the namespace conflicts

Description

Mandatory Checklist

Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
- General release
- Public preview
- Private preview
- Engineering build
- No need for a release
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

…tiple projects Assumption: transitive dependency, not referenced directly by code, OK to be provided by Az.Accounts at runtime

azure-client-tools-bot-prd · 2026-05-05T16:40:55Z

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

scottaddie · 2026-05-05T18:32:09Z

@@ -22,10 +22,12 @@ namespace Microsoft.Azure.PowerShell.Authenticators.Factories
 {
    public class AzureCredentialFactory
    {
+#pragma warning disable CS0618 // ManagedIdentityCredential(string) is obsolete; suppressed pending migration to ManagedIdentityId API
        public virtual TokenCredential CreateManagedIdentityCredential(string clientId)
        {
            return new ManagedIdentityCredential(clientId);


To avoid more testing down the road, switch to the replacement overload for user-assigned managed identity with client ID. Then you can remove the warning suppression for this method.

Suggested change

return new ManagedIdentityCredential(clientId);

return new ManagedIdentityCredential(ManagedIdentityId.FromUserAssignedClientId(clientId));

scottaddie · 2026-05-05T18:38:47Z

@@ -56,8 +56,10 @@ public async Task UserAssignedMSI()

            var mockAzureCredentialFactory = new Mock<AzureCredentialFactory>();
            //id must be equal to accountId
+#pragma warning disable CS0618 // ManagedIdentityCredential(string) is obsolete; suppressed pending migration
            mockAzureCredentialFactory.Setup(f => f.CreateManagedIdentityCredential(It.Is<string>(id => id == accountId)))
                .Returns(new ManagedIdentityCredential(accountId));


See my other comment about using the replacement overload

Copilot

Pull request overview

Copilot reviewed 35 out of 62 changed files in this pull request and generated 11 comments.

Comments suppressed due to low confidence (2)

src/Search/Search/Models/PSIdentity.cs:33

The explicit conversion operator parameter type is Azure.Management.Search.Models.Identity, but this module’s SDK types are in Microsoft.Azure.Management.Search.Models (and the file already imports that namespace). This will not compile unless an Azure.Management.Search.Models namespace exists. Update the operator signature to use the SDK Identity type.

        public PSIdentityType Type { get; set; }

        public static explicit operator PSIdentity(Azure.Management.Search.Models.Identity v)
        {
            PSIdentityType? identityType = v?.Type.ParsePSIdentityType();

            if (identityType.HasValue)

src/OperationalInsights/OperationalInsights/Models/PSIdentity.cs:33

The file imports Microsoft.Azure.Management.OperationalInsights.Models, but the constructor parameter type is Management.OperationalInsights.Models.Identity, which doesn’t resolve without a Management namespace alias. This will fail compilation; use the SDK Identity type from the imported namespace (or fully-qualify Microsoft.Azure.Management.OperationalInsights.Models.Identity).

            TenantId = tenantId;
            Type = string.IsNullOrEmpty(type) ? "SystemAssigned" : type;
        }

        public PSIdentity(Management.OperationalInsights.Models.Identity identity)
        {
            this.PrincipalId = identity.PrincipalId;
            this.TenantId = identity.TenantId;
            this.Type = identity.Type.ToString();
        }

                        NetworkRuleSet = networkRuleSet ?? service.NetworkRuleSet,
                        PublicNetworkAccess = publicNetworkAccess ?? service.PublicNetworkAccess,
-                        Identity = (Identity)identity ?? service.Identity,
+                        Identity = (Azure.Management.Search.Models.Identity)identity ?? service.Identity,


                    publicNetworkAccess: publicNetworkAccess,
-                    identity: (Identity)identity,
+                    identity: (Azure.Management.Search.Models.Identity)identity,
                    networkRuleSet: networkRuleSet,


        }

-        public static explicit operator Identity(PSIdentity v)
+        public static explicit operator Azure.Management.Search.Models.Identity(PSIdentity v)
        {
            string identityType = v?.Type.ToString();
            if (identityType != null)
            {
-                return new Identity(
+                return new Azure.Management.Search.Models.Identity(
                    type: identityType,
                    principalId: v?.PrincipalId,
                    tenantId: v?.TenantId);


        public string PublicNetworkAccess { get; private set; }

-        public Identity Identity { get; private set; }
+        public Azure.Management.CognitiveServices.Models.Identity Identity { get; private set; }


                }

-                updateParameters.Identity = new Identity(resourceIdentityType);
+                updateParameters.Identity = new Azure.Management.CognitiveServices.Models.Identity(resourceIdentityType);


        }

-        public Identity GetIdentity()
+        public Management.OperationalInsights.Models.Identity GetIdentity()
        {
-            return new Identity(this.getIdentityType(), this.PrincipalId, this.TenantId);
+            return new Management.OperationalInsights.Models.Identity(this.getIdentityType(), this.PrincipalId, this.TenantId);
        }


@@ -18,7 +18,6 @@
    <PackageReference Include="Portable.BouncyCastle" Version="1.8.8" />
    <PackageReference Include="Microsoft.Azure.KeyVault" Version="3.0.1" />
    <PackageReference Include="Microsoft.Azure.KeyVault.WebKey" Version="3.0.1" />


+	<ProjectReference Include="..\RecoveryServices.Backup.CrossRegionRestore.Management.Sdk\RecoveryServices.Backup.CrossRegionRestore.Management.Sdk.csproj" />
  </ItemGroup>

  <ItemGroup>


+            if (clientId != null)
+            {
+                return new ManagedIdentityCredential(ManagedIdentityId.FromUserAssignedClientId(clientId));
+            }
+            return new ManagedIdentityCredential(ManagedIdentityId.SystemAssigned);


+- [x] create an agent
+- [x] update azure.identity and msal
+  - [x] address namespace conflict of types named Identity because Azure.Core pulls in namespaces of Microsoft.Identity (because of Microsoft.Identity.Client)
+- [x] update other dependencies
+- [ ] System.Text.Json might not be necessary for PowerShell 7+?
+- [ ] Errors of "Could not load file or assembly 'Microsoft.Azure.PowerShell.AssemblyLoading, Version=5.3.3.0" during smoke test. Might be regression of parallal loading, need to investigate.


scottaddie · 2026-05-08T14:00:14Z

-    <PackageReference Include="Microsoft.Identity.Client" Version="4.82.1" />
-    <PackageReference Include="Microsoft.Identity.Client.Extensions.Msal" Version="4.82.1" />
-    <PackageReference Include="Microsoft.Identity.Client.Broker" Version="4.82.1" />
+    <PackageReference Include="Azure.Identity" Version="1.21.0" />


You'll need to use this version of Azure.Core instead, so that extra querystring parameters can be passed via the new AdditionalQueryParameters property. All the Azure.Identity credentials you need live in Azure.Core now.

Suggested change

<PackageReference Include="Azure.Identity" Version="1.21.0" />

<PackageReference Include="Azure.Core" Version="1.55.0" />

scottaddie · 2026-05-08T14:06:07Z

  </ItemGroup>
  <ItemGroup>
-    <PackageReference Include="Azure.Core" Version="1.50.0"/>
+    <PackageReference Include="Azure.Core" Version="1.54.0"/>


Bump to latest stable release

Suggested change

<PackageReference Include="Azure.Core" Version="1.54.0"/>

<PackageReference Include="Azure.Core" Version="1.55.0"/>

isra-fel added 4 commits May 5, 2026 12:10

Update dependencies and suppress warnings for obsolete credential types

8d6b1f2

todo

460d603

Update package references and clean up unused dependencies across mul…

92e2949

…tiple projects Assumption: transitive dependency, not referenced directly by code, OK to be provided by Az.Accounts at runtime

continue addressing the namespace conflicts

dda7dde

Copilot AI review requested due to automatic review settings May 5, 2026 16:40

Copilot AI reviewed May 5, 2026

View reviewed changes

scottaddie reviewed May 5, 2026

View reviewed changes

isra-fel added 2 commits May 8, 2026 14:16

Merge branch 'main' into azure-identity-1.21.0

e51ad43

Refactor ManagedIdentityCredential creation to use ManagedIdentityId API

ac3637b

Copilot AI review requested due to automatic review settings May 8, 2026 04:43

Copilot started reviewing on behalf of isra-fel May 8, 2026 04:45 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

scottaddie reviewed May 8, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update auth lib to latest#29505

Update auth lib to latest#29505
isra-fel wants to merge 6 commits intoAzure:mainfrom
isra-fel:azure-identity-1.21.0

isra-fel commented May 5, 2026

Uh oh!

azure-client-tools-bot-prd Bot commented May 5, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

scottaddie May 5, 2026

Uh oh!

scottaddie May 5, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

scottaddie May 8, 2026

Uh oh!

scottaddie May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	return new ManagedIdentityCredential(clientId);
	return new ManagedIdentityCredential(ManagedIdentityId.FromUserAssignedClientId(clientId));

	<PackageReference Include="Azure.Identity" Version="1.21.0" />
	<PackageReference Include="Azure.Core" Version="1.55.0" />

Conversation

isra-fel commented May 5, 2026

Description

Mandatory Checklist

Uh oh!

azure-client-tools-bot-prd Bot commented May 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

scottaddie May 5, 2026

Choose a reason for hiding this comment

Uh oh!

scottaddie May 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

scottaddie May 8, 2026

Choose a reason for hiding this comment

Uh oh!

scottaddie May 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants