perf(json): parse directly from string buffers#5108
Open
SaveTheRbtz wants to merge 1 commit into
Open
Conversation
This was referenced Jun 6, 2026
Author
|
cc @zjeffer @xander1421 @Alexays, you look like the most relevant reviewers from git history:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JsonParserinput with JsonCppCharReaderdirectly from the existing string buffer.\xescape compatibility, but only allocate and runregex_replacewhen that escape is present.Why this was needed
baseline.perf.datashowed the JSON utility paying a large common-case regex tax before parsing:std::regexsearch/replace: about 1.10B child cyclesstd::regex::_M_dfs: 743M self cyclesChange
Parse from the existing string buffer with JsonCpp's
CharReader. Preserve the\xcompatibility repair, but first check whether the escape is present so the common path avoids allocating a modified string and running regex replacement.Effect in comparison
The regex path disappears from visible hot symbols. Json parse work drops from 834M to 188M cycles, and the overall JsonCpp bucket drops from roughly 700M to 186M cycles.
Testing
ninja -C buildmeson test -C build