perf(json): parse directly from string buffers#2
Closed
SaveTheRbtz wants to merge 1 commit into
Closed
Conversation
SaveTheRbtz
force-pushed
the
codex-json-parser-buffer
branch
from
488827c to
5cce616
Compare
SaveTheRbtz
changed the title
Owner
Author
|
Closed in favor of upstream PR: Alexays#5108 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JsonParserinput with JsonCppCharReaderdirectly from the existing string buffer.\xescape compatibility, but only allocate and runregex_replacewhen that escape is present.Why
Profiles showed time in JsonCpp plus allocation/string work. This removes common-case parser overhead without changing callers, parsed output, or the JsonCpp dependency.
Testing
ninja -C buildmeson test -C build