Implement dark mode using win32-darkmodelib by lostindark · Pull Request #1203 · zufuliu/notepad4

lostindark · 2026-04-07T01:09:29Z

Vendor ozone10/win32-darkmodelib source files directly in darkmodelib/ to provide native Windows dark mode support for Notepad4's UI chrome, tied to the existing Style Theme (Default/Dark) setting.

Features:

Dark title bar, menu bar, context menus (via system dark mode APIs)
Dark toolbar, rebar, status bar with darkmodelib subclassing
Dark tooltips and scrollbars
All dialogs automatically themed via WH_CALLWNDPROCRET hook on WM_INITDIALOG (no per-dialog-proc changes needed)
Toolbar Customize dialog fixed with temporary SetSysColors override
Custom color hierarchy for visual depth: Editor #1E1E1E / Dialogs #252526 / Toolbar #2D2D2D / Controls #383838
View colors for list boxes, list views, tree views, and headers
Theme switching via View > Style Theme toggles dark mode on/off
WM_SETTINGCHANGE handled for system dark/light mode changes

zufuliu · 2026-04-07T11:52:10Z

Please wait a bit, looks win32-darkmodelib has too many codes (main branch 1M lines, old win32-darkmode only has hundred lines).

D:\Libs\win32-darkmodelib\src>perl d:\Dev\MSYS2\opt\bin\cloc.pl .
      27 text files.
      27 unique files.
       0 files ignored.

github.com/AlDanial/cloc v 2.08  T=0.08 s (322.6 files/s, 164987.9 lines/s)
---------------------------------------------------------------------------------------
Language                             files          blank        comment           code
---------------------------------------------------------------------------------------
C++                                     10           1264           3192           6641
C/C++ Header                            15            366            589           1532
Windows Module Definition                1              0              0            183
Windows Resource File                    1              2              4             34
---------------------------------------------------------------------------------------
SUM:                                    27           1632           3785           8390
---------------------------------------------------------------------------------------

I don't understand why it's need to subcalss all common controls.

lostindark · 2026-04-08T03:23:49Z

Please wait a bit, looks win32-darkmodelib has too many codes (main branch 1M lines, old win32-darkmode only has hundred lines).

D:\Libs\win32-darkmodelib\src>perl d:\Dev\MSYS2\opt\bin\cloc.pl .
      27 text files.
      27 unique files.
       0 files ignored.

github.com/AlDanial/cloc v 2.08  T=0.08 s (322.6 files/s, 164987.9 lines/s)
---------------------------------------------------------------------------------------
Language                             files          blank        comment           code
---------------------------------------------------------------------------------------
C++                                     10           1264           3192           6641
C/C++ Header                            15            366            589           1532
Windows Module Definition                1              0              0            183
Windows Resource File                    1              2              4             34
---------------------------------------------------------------------------------------
SUM:                                    27           1632           3785           8390
---------------------------------------------------------------------------------------

I don't understand why it's need to subcalss all common controls.

Isn't the code 8k lines?

Those common controls won't render correctly in dark mode. Some part of the control will still rendering the way in light theme. E.g. buttons render as light, or some background render as light.

I didn't find a simple way to fix them without subclass them. In fact notepad++ also does the same way (subclass those controls).

zufuliu · 2026-04-09T10:33:56Z

Isn't the code 8k lines?

It matters at least for matepath:

D:\notepad4\notepad4\matepath\src>perl d:\Dev\MSYS2\opt\bin\cloc.pl .
      20 text files.
      18 unique files.
       2 files ignored.

github.com/AlDanial/cloc v 2.08  T=0.09 s (200.3 files/s, 132208.7 lines/s)
-----------------------------------------------------------------------------------
Language                         files          blank        comment           code
-----------------------------------------------------------------------------------
C++                                  5           1343           1129           7268
C/C++ Header                        10            174            213           1090
Windows Resource File                1             58             61            540
DOS Batch                            2              0              0              6
-----------------------------------------------------------------------------------
SUM:                                18           1575           1403           8904
-----------------------------------------------------------------------------------

lostindark · 2026-04-21T04:06:49Z

Isn't the code 8k lines?

It matters at least for matepath:

D:\notepad4\notepad4\matepath\src>perl d:\Dev\MSYS2\opt\bin\cloc.pl .
      20 text files.
      18 unique files.
       2 files ignored.

github.com/AlDanial/cloc v 2.08  T=0.09 s (200.3 files/s, 132208.7 lines/s)
-----------------------------------------------------------------------------------
Language                         files          blank        comment           code
-----------------------------------------------------------------------------------
C++                                  5           1343           1129           7268
C/C++ Header                        10            174            213           1090
Windows Resource File                1             58             61            540
DOS Batch                            2              0              0              6
-----------------------------------------------------------------------------------
SUM:                                18           1575           1403           8904
-----------------------------------------------------------------------------------

matepath is a different project right? Haven't looked into support darkmode on it yet.

Matteo-Nigro · 2026-05-03T08:54:44Z

This is a long overdue feature, it would be nice to be able to implement it. 💪🏻
If with the Dark mod of the toolbar the icons are unclear let me know and I will update them or review them 🖌️

Casonctin · 2026-05-20T16:03:42Z

After testing, I found that the scroll bar is white and the save changes dialog.

Address PR zufuliu#1203 feedback: scroll bars and the save-changes dialog were rendered in the light theme even when dark mode is active. - Enable scroll bar fix in darkmodelib (mode 2: per-window) and rely on the existing enableDarkScrollBarForWindowAndChildren(hwndMain) call so the Scintilla edit window's scroll bars use the dark theme. - Route Notepad4's MsgBox() through dmlib::darkMessageBoxW(), which renders message boxes as themed task dialogs when dark mode is on. - Fix two upstream darkmodelib namespacing bugs that surface when _DARKMODELIB_USE_SCROLLBAR_FIX is defined (DmlibHook.cpp uses ModuleHandle / LoadFn without the dmlib_module:: prefix). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

lostindark · 2026-05-21T16:23:23Z

After testing, I found that the scroll bar is white and the save changes dialog.

This should be fixed now.

Casonctin · 2026-05-21T18:41:17Z

After testing, I found that the scroll bar is white and the save changes dialog.

This should be fixed now.

Confirmed its fixed. Every dialog and popup is now in dark mode! Thank you!

Matteo-Nigro · 2026-05-22T09:26:00Z

Great job, @lostindark it looks really nice now. Well done!
Just a quick note: the toolbars' button rollovers still use the old (light) style.
Unlike the menu bar, which uses the dark style for its rollovers.

Address PR zufuliu#1203 feedback: scroll bars and the save-changes dialog were rendered in the light theme even when dark mode is active. - Enable scroll bar fix in darkmodelib (mode 2: per-window) and rely on the existing enableDarkScrollBarForWindowAndChildren(hwndMain) call so the Scintilla edit window's scroll bars use the dark theme. - Route Notepad4's MsgBox() through dmlib::darkMessageBoxW(), which renders message boxes as themed task dialogs when dark mode is on. - Fix two upstream darkmodelib namespacing bugs that surface when _DARKMODELIB_USE_SCROLLBAR_FIX is defined (DmlibHook.cpp uses ModuleHandle / LoadFn without the dmlib_module:: prefix). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Address PR zufuliu#1203 feedback so that scroll bars, message boxes, the file open/save dialog, and toolbar button rollovers all render correctly when dark mode is toggled on or off. - Enable per-window scroll bar fix in darkmodelib (mode 2) so the Scintilla edit window's scroll bars use the dark theme via the existing enableDarkScrollBarForWindowAndChildren(hwndMain) call. - Route Notepad4's MsgBox() through dmlib::darkMessageBoxW(), which renders message boxes as themed task dialogs when dark mode is on. - Broadcast WM_THEMECHANGED to hwndMain and all descendants after a theme switch so themed controls (including scroll bars) re-open their theme handles and pick up the new light/dark style. - Gate the OpenNcThemeData IAT hook on IsDarkModeActive() so scroll bars revert to the light theme after switching back from dark. - Gate the WM_INITDIALOG thread hook on isExperimentalActive() and on the dialog's HINSTANCE matching this app's module, so system dialogs hosted in our process (common file open/save, etc.) are left untouched. - Subclass the main window with setWindowNotifyCustomDrawSubclass so darkmodelib can custom-draw toolbar buttons (dark hover/checked states) via the toolbar's NM_CUSTOMDRAW notifications, which the rebar forwards up to its parent. This matches Notepad++'s approach. - Fix two upstream darkmodelib namespacing bugs that surface when _DARKMODELIB_USE_SCROLLBAR_FIX is defined (DmlibHook.cpp uses ModuleHandle / LoadFn without the dmlib_module:: prefix). - Add missing #include <string_view> in DmlibHook.cpp so MinGW GCC/Clang builds compile (upstream pulls this in via StdAfx.h which we do not vendor). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

lostindark · 2026-05-25T20:22:16Z

Great job, @lostindark it looks really nice now. Well done! Just a quick note: the toolbars' button rollovers still use the old (light) style. Unlike the menu bar, which uses the dark style for its rollovers.

Fixed in latest commit.

zufuliu · 2026-06-11T10:22:48Z

Appearance for default theme is not good and doesn't match system default (looks old classic theme):

Above is old system default (white background for menubar and toolbar), below is new (grey background for menubar and toolbar).

This change increase exe size by 93KB, I think we needs some custom/samll version of darkmodelib, at least bugprone-exception-escape warnings needs to be fixed (e.g. by not use C++ STL).

lostindark · 2026-06-15T07:24:38Z

Appearance for default theme is not good and doesn't match system default (looks old classic theme): Above is old system default (white background for menubar and toolbar), below is new (grey background for menubar and toolbar).

This change increase exe size by 93KB, I think we needs some custom/samll version of darkmodelib, at least bugprone-exception-escape warnings needs to be fixed (e.g. by not use C++ STL).

Both issues fixed. Though the smaller version of darmodelib might be tricky.

Vendor the win32-darkmodelib library (https://github.com/ozone10/win32-darkmodelib) under darkmodelib/, mirroring upstream's src/ + include/ layout. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Integrate darkmodelib into Notepad4: dark mode application logic (DarkMode.cpp/.h and calls from Notepad4.cpp, Styles.cpp, Dialogs.cpp), build wiring for the darkmodelib library, and the local patches to the vendored library (disableDarkScrollBarForWindowAndChildren and the light/dark toolbar theming color fixes). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

lostindark · 2026-06-17T23:24:02Z

Rework the integration, so the change is a bit easier to read.

Casonctin · 2026-06-19T16:28:13Z

To be honest, the old menu color looked better. There's now a space between the menu and the toolbar.

zufuliu · 2026-06-20T01:53:27Z

smaller version of darmodelib might be tricky.

I'm still prefer custom smaller version:

DPI related functions already loaded by Scintilla_LoadDpiForWindow().
cast FAPROC to target function with reinterpret_cast is poor, DLLFunction (__builtin_bit_cast) can be used.
using C++ STL in Win32 callback without try/catch, the code can be changed to use local buffer.

deferred this to next release, I need some time to fix Markdown lexer crashes.

zufuliu added ui ui: dark mode labels Apr 7, 2026

zufuliu modified the milestones: v26.05, v26.07 May 5, 2026

zufuliu added the ✅enhancement label May 5, 2026

lostindark force-pushed the main branch from ccb6ce0 to 2552432 Compare May 21, 2026 00:09

lostindark force-pushed the main branch from 2552432 to 4deb600 Compare May 21, 2026 00:22

zufuliu linked an issue May 23, 2026 that may be closed by this pull request

Dark Mode #105

Open

lostindark force-pushed the main branch from 4deb600 to a1981f4 Compare May 23, 2026 05:42

lostindark force-pushed the main branch from a1981f4 to 652ccf4 Compare May 23, 2026 05:46

lostindark force-pushed the main branch from 652ccf4 to 340b5aa Compare May 23, 2026 05:50

lostindark force-pushed the main branch from 340b5aa to bb2e98b Compare May 23, 2026 05:51

lostindark and others added 2 commits June 17, 2026 15:31

Pull in darkmodelib files

d13acf5

Vendor the win32-darkmodelib library (https://github.com/ozone10/win32-darkmodelib) under darkmodelib/, mirroring upstream's src/ + include/ layout. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

lostindark force-pushed the main branch from b8c5780 to db3a387 Compare June 17, 2026 23:15

zufuliu removed this from the v26.07 milestone Jun 20, 2026

Conversation

lostindark commented Apr 7, 2026

Uh oh!

zufuliu commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lostindark commented Apr 8, 2026

Uh oh!

zufuliu commented Apr 9, 2026

Uh oh!

lostindark commented Apr 21, 2026

Uh oh!

Matteo-Nigro commented May 3, 2026

Uh oh!

Casonctin commented May 20, 2026

Uh oh!

lostindark commented May 21, 2026

Uh oh!

Casonctin commented May 21, 2026

Uh oh!

Matteo-Nigro commented May 22, 2026

Uh oh!

lostindark commented May 25, 2026

Uh oh!

zufuliu commented Jun 11, 2026

Uh oh!

lostindark commented Jun 15, 2026

Uh oh!

lostindark commented Jun 17, 2026

Uh oh!

Casonctin commented Jun 19, 2026

Uh oh!

zufuliu commented Jun 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

zufuliu commented Apr 7, 2026 •

edited

Loading