Don't generate errors when searching customer user#744
Open
pboguslawski wants to merge 5 commits intoznuny:rel-6_5-devfrom
Open
Don't generate errors when searching customer user#744pboguslawski wants to merge 5 commits intoznuny:rel-6_5-devfrom
pboguslawski wants to merge 5 commits intoznuny:rel-6_5-devfrom
Conversation
When agent searches for customer user with spaces only (i.e. entering 4 spaces into `Customer user` field on new phone ticket page) application generates errors like ``` Message: Need Search, UserLogin, PostMasterSearch, CustomerIDRaw or CustomerID! ``` in ``` Module: Kernel::System::CustomerUser::DB::CustomerSearch Line: 272 Module: Kernel::System::CustomerUser::LDAP::CustomerSearch Line: 384 ``` This mod fixes it by returning empty set if no search parameters are defined (after spaces are removed from search pattern). Corresponding error message is fixed in `Kernel/System/CustomerUser/LDAP.pm` also to contain all accepted search parameters. Author-Change-Id: IB#1156084 Signed-off-by: Pawel Boguslawski <pawel.boguslawski@ib.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
When agent searches for customer user with spaces only (i.e. entering 4 spaces into
Customer userfield on new phone ticket page) application generates errors likein
This mod fixes it by returning empty set if no search parameters are defined (after spaces are removed from search pattern).
Corresponding error message is fixed in
Kernel/System/CustomerUser/LDAP.pmalso to contain all accepted search parameters.Type of change
Additional information
Author-Change-Id: IB#1156084
Checklist