Skip to content

Sector Nord AG: Bugfix AgentTicketMove - RequiredLock should be needed for the TicketLockCheck#716

Open
LuBroering wants to merge 3 commits intoznuny:devfrom
SectorNordAG:AgentTicketMoveRequireLockFix
Open

Sector Nord AG: Bugfix AgentTicketMove - RequiredLock should be needed for the TicketLockCheck#716
LuBroering wants to merge 3 commits intoznuny:devfrom
SectorNordAG:AgentTicketMoveRequireLockFix

Conversation

@LuBroering
Copy link
Copy Markdown
Contributor

Proposed change

This fix ensures that AgentTicketMove can be used even if a ticket is locked by another user, provided that RequiredLock is set to 0. If RequiredLock is set to 1, the TicketLock and Owner will be updated.

Type of change

  • '1 - 🐞 bug 🐞' - Bugfix (non-breaking change which fixes an issue)

Breaking change

Previously, it could be assumed that only owners were able to move locked tickets. This fix changes that behavior.

Additional information

This changed behavior is consistent with the handling in other masks, such as AgentTicketActionCommon. When the mask is executed, both the owner and lock are updated if RequiredLock is set.

Checklist

  • The code change is tested and works locally.(❗)
  • There is no commented out code in this PR.(❕)
  • You improved or added new unit tests.(❕)
  • Local ZnunyCodePolicy passed.(❕)
  • Local UnitTests / Selenium passed.(❕)
  • GitHub workflow CI (UnitTests / Selenium) passed.(❗)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant