Add parameter SMIME::NoDefaultCA and remove unnecessary parameter#681
Open
pboguslawski wants to merge 4 commits intoznuny:rel-6_5-devfrom
Open
Add parameter SMIME::NoDefaultCA and remove unnecessary parameter#681pboguslawski wants to merge 4 commits intoznuny:rel-6_5-devfrom
pboguslawski wants to merge 4 commits intoznuny:rel-6_5-devfrom
Conversation
Znuny does not disable OS default CA certificate sources on S/MIME verification which may lead to different verification results in different environments with same certs in `SMIME::CertPath`. For example: signature not trusted in Debian 11 may be trusted after upgrade to Debian 12 where default trust was modified: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=805646 This mod adds `SMIME::NoDefaultCA` (disabled by default for backward compatibility) to allow one to skip default OS CAs on S/MIME verification (and use trust only CAs in `SMIME::CertPath` like in Debian 11). This mod also removes unnecessary parameter from `openssl smime -verify` command. Related: https://docs.openssl.org/master/man1/openssl-verification-options/#trusted-certificate-options Author-Change-Id: IB#1161846 Signed-off-by: Pawel Boguslawski <pawel.boguslawski@ib.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Znuny does not disable OS default CA certificate sources on S/MIME verification which may lead to different verification results in different environments with same certs in
SMIME::CertPath. For example: signature not trusted in Debian 11 may be trusted after upgrade to Debian 12 where default trust was modified.This mod adds
SMIME::NoDefaultCA(disabled by default for backward compatibility) to allow one to skip default OS CAs on S/MIME verification (and use trust only CAs inSMIME::CertPathlike in Debian 11).This mod also removes unnecessary parameter from
openssl smime -verifycommand.Type of change
Additional information
Related: https://docs.openssl.org/master/man1/openssl-verification-options/#trusted-certificate-options
Author-Change-Id: IB#1161846
Checklist