Efflux: Disable logging of plaintext passwords in debugging mode (CVE-2024-43444)#588
Open
Efflux: Disable logging of plaintext passwords in debugging mode (CVE-2024-43444)#588
Conversation
Contributor
Author
|
I’ve made some changes to make the PR more consistent. In my understanding of security, an application should never write passwords in plain text to a log file. If crypt type is set to plain, for whatever reason, even passwords retrieved from the database are logged in plain text. |
58ba4d7 to
aa65bbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Disable the logging of plaintext passwords in debugging mode.
Type of change
Additional information
This is inspired by CVE-2024-43444. I'd not consider this a security patch, as the debugging mode can only be enabled by changing the source code. And if you have access to the source code, you can debug anything.
Checklist