Fall back to non-EDNS queries on FORMERR - #618
Open
lattwood wants to merge 1 commit into
Open
Conversation
Retry ordinary UDP and TCP queries without EDNS when a server returns FORMERR without an OPT record. Preserve EDNS when it is required by DNSSEC or explicit options. Fixes zmap#617
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ZDNS always adds an EDNS OPT record to queries. Some authoritative servers return
FORMERRwhen EDNS is present but answer the same query normally without it.If we get
FORMERRwithout an OPT record in the response, retry the same nameserver without EDNS.There are a few guardrails:
FORMERRresponse contains OPT—the server understood EDNS in that case.This applies to UDP, TCP, DoT, and DoH, and leaves the existing UDP-to-TCP truncation behavior alone.
Testing
Added coverage for:
FORMERRresponses with and without OPT.FORMERRfollowed by a delayed successful response throughExternalLookup, verifying that both wire operations get a fullNetworkTimeout.Also ran:
go test ./...golangci-lint run ./...Fixes #617