Allow disabling Sonoff SWV "Water shortage auto-close" #4207
Merged
Conversation
Added support for turning off "Auto close when water shortage" Ids according to: https://github.com/Koenkk/zigbee-herdsman-converters/blob/master/src/devices/sonoff.ts
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4207 +/- ##
=======================================
Coverage 92.03% 92.03%
=======================================
Files 350 350
Lines 11602 11603 +1
=======================================
+ Hits 10678 10679 +1
Misses 924 924 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: TheJulianJES <TheJulianJES@users.noreply.github.com>
Collaborator
TheJulianJES
left a comment
There was a problem hiding this comment.
Ok, I'll change up a few names and then merge this.
TheJulianJES
approved these changes
Jul 30, 2025
Contributor
Author
|
Thank you for handling this PR! |
Collaborator
|
Thanks for creating it! 😄 |
totoroot
pushed a commit
to totoroot/zha-device-handlers
that referenced
this pull request
Feb 18, 2026
Co-authored-by: TheJulianJES <TheJulianJES@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SWV has a function to turn off water automatically, when no or low water flow is detected. This is a problem for drip irrigation, for example.
In Firmware version 1.0.4 a function was introduced to turn off this behavior:
Proposed change
I propose to add a switch to the existing quirk that allows to use this function from HA.
Additional information
This PR is complementary to #3930. However, accessing "Auto close when water shortage" via ZHA commands is only possible with a modified quirk.
Checklist
pre-commitchecks pass / the code has been formatted using Black