Log time until next MTORR broadcast for source routing#717
Draft
TheJulianJES wants to merge 1 commit intozigpy:devfrom
Draft
Log time until next MTORR broadcast for source routing#717TheJulianJES wants to merge 1 commit intozigpy:devfrom
TheJulianJES wants to merge 1 commit intozigpy:devfrom
Conversation
`setSourceRouteDiscoveryMode` returns a `uint32_t remainingTime` —
the milliseconds until the next MTORR broadcast — but bellows was
discarding it. Capture and log it at debug level. With the
`RESCHEDULE` mode this is approximately the configured min-interval;
the value makes startup behavior visible in logs and matches what
zigbee-herdsman's ember adapter reports
("Started source route discovery. Xms until next broadcast.").
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #717 +/- ##
=======================================
Coverage 99.54% 99.54%
=======================================
Files 61 61
Lines 4147 4148 +1
=======================================
+ Hits 4128 4129 +1
Misses 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI summary
setSourceRouteDiscoveryModereturns auint32_t remainingTime— the milliseconds until the next MTORR broadcast — but bellows was discarding it. Capture and log it at debug level. With theRESCHEDULEmode this is approximately the configured min-interval; the value makes startup behavior visible in logs and matches what zigbee-herdsman's ember adapter reports("Started source route discovery. Xms until next broadcast.").