Skip to content
This repository was archived by the owner on Jan 21, 2020. It is now read-only.

[wip] zf-configuration patchKey fix - #390

Open
TomHAnderson wants to merge 1 commit into
zfcampus:masterfrom
TomHAnderson:hotfix/patchKey
Open

[wip] zf-configuration patchKey fix#390
TomHAnderson wants to merge 1 commit into
zfcampus:masterfrom
TomHAnderson:hotfix/patchKey

Conversation

@TomHAnderson

@TomHAnderson TomHAnderson commented Mar 19, 2018

Copy link
Copy Markdown
Contributor

This PR will require zfcampus/zf-configuration#30
This is a fix for the incorrect, and now corrected, zf-configuration.

The fix strategy is to change patchKey calls to replaceKey, but only where necessary.

@TomHAnderson TomHAnderson changed the title [wip] Hotfix/patch key [wip] zf-configuration patchKey fix Mar 19, 2018
@weierophinney

Copy link
Copy Markdown
Member

This repository has been closed and moved to laminas-api-tools/api-tools-admin; a new issue has been opened at laminas-api-tools/api-tools-admin#5.

@weierophinney

Copy link
Copy Markdown
Member

This repository has been moved to laminas-api-tools/api-tools-admin. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas-api-tools/api-tools-admin to another directory.
  • Copy the files from the second bullet point to the clone of laminas-api-tools/api-tools-admin.
  • In your clone of laminas-api-tools/api-tools-admin, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants